[ https://issues.apache.org/jira/browse/CLOUDSTACK-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727575#comment-13727575 ]
ASF subversion and git services commented on CLOUDSTACK-3753: ------------------------------------------------------------- Commit 6e83a54ffbf69e46a79fbaf0be63e63092385b65 in branch refs/heads/4.2 from [~bharat.kumar] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6e83a54 ] CLOUDSTACK-3753 fixed the test test_non_contigiousvlan.py Signed-off-by: Prasanna Santhanam <t...@apache.org> > Multiple VLAN range API need to accept a list rather than "add" or "remove" > per command > --------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-3753 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3753 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller > Affects Versions: 4.2.0 > Reporter: Sheng Yang > Assignee: Bharat Kumar > Priority: Blocker > Fix For: 4.2.0 > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Non+contiguous+vlan+ranges > "vlan parameter will add a new vlan range to the existing vlan range (new > behavior). if the new vlan range overlaps the existing vlan range it will > extend that vlan (This is the existing behavior.). > removevlan parameter will remove the mentioned vlan. The removevlan and vlan > parameters can be used together. If the vlan range we are trying to remove is > in use, the operation will not succeed." > I haven't seen such API in the CloudStack. It's much more clean to use a list > here(even for ranges, can be extended from one element, like "1-2, 4-5, > 6-7"), rather than newly defined "vlan"/"removevlan" behavior. It broke API > compatibility(e.g. the previous API potentially able to change vlan directly, > rather than add it), and is also user unfriendly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira