[
https://issues.apache.org/jira/browse/CLOUDSTACK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Santhosh Kumar Edukulla updated CLOUDSTACK-5056:
------------------------------------------------
Description:
Logging this bug to track issues with ssh library of marvin:
1. The library in it current form has some issues. As part of that, did clean
up of the code.
2. Added tcp timeout flag as an additional parameter to help establish the tcp
connections and retry if failed. It retries even otherwise failed.
3. Renamed few variables and maintained uniform usage and convention.
4. Added few new member functions runCommand,createConnection
5. Current, way of creating connection and raising exception from constructor
along with return was removed and added a new way of handling it.
6. Currently, result list was returned for execute command, but we dont know
the status of command execution, whether the output contains error or output
etc. Now, provided more information in the return with new implementation.
7. Added few codes for proper return status.
TODO:
1. Remove establishing connection from constructor altogether. This will effect
the current modules using it.
2. Need to change is_server_ssh_ready function for proper and adequate checks,
currently the name and functionality is little different. It can add more
adequate checks before returning ssh object.
was:
1. The library in it current form has some issues. As part of that, did clean
up of the code.
2. Added tcp timeout flag as an additional parameter to help establish the tcp
connections and retry if failed. It retries even otherwise failed.
3. Renamed few variables and maintained uniform usage and convention.
4. Added few new member functions runCommand,createConnection
5. Current, way of creating connection and raising exception from constructor
along with return was removed and added a new way of handling it.
6. Currently, result list was returned for execute command, but we dont know
the status of command execution, whether the output contains error or output
etc. Now, provided more information in the return with new implementation.
7. Added few codes for proper return status.
TODO:
1. Remove establishing connection from constructor altogether. This will effect
the current modules using it.
2. Need to change is_server_ssh_ready function for proper and adequate checks,
currently the name and functionality is little different. It can add more
adequate checks before returning ssh object.
> Cleaning up SSH library
> -----------------------
>
> Key: CLOUDSTACK-5056
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5056
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation, marvin
> Reporter: Santhosh Kumar Edukulla
>
> Logging this bug to track issues with ssh library of marvin:
> 1. The library in it current form has some issues. As part of that, did clean
> up of the code.
> 2. Added tcp timeout flag as an additional parameter to help establish the
> tcp connections and retry if failed. It retries even otherwise failed.
> 3. Renamed few variables and maintained uniform usage and convention.
> 4. Added few new member functions runCommand,createConnection
> 5. Current, way of creating connection and raising exception from constructor
> along with return was removed and added a new way of handling it.
> 6. Currently, result list was returned for execute command, but we dont know
> the status of command execution, whether the output contains error or output
> etc. Now, provided more information in the return with new implementation.
> 7. Added few codes for proper return status.
> TODO:
> 1. Remove establishing connection from constructor altogether. This will
> effect the current modules using it.
> 2. Need to change is_server_ssh_ready function for proper and adequate
> checks, currently the name and functionality is little different. It can add
> more adequate checks before returning ssh object.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
