[ https://issues.apache.org/jira/browse/CLOUDSTACK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918796#comment-13918796 ]
Marcus Sorensen edited comment on CLOUDSTACK-6181 at 3/4/14 12:33 AM: ---------------------------------------------------------------------- Ok, I've got initial support for passing rootdisksize parameter in that branch. It works for local, NFS, and CLVM on KVM. I implemented RBD but have not tested. Before I can request merge, a few things need to happen. 1. Someone else needs to run some tests and verify the work, and perhaps we need to fix a few things as they come up. 2. We need a few smoke tests written that try the rootdisksize parameter and verify they work with KVM and fail with other hypervisors. I'm not really up to speed on the current testing infra and this might take me awhile if we can't find someone who is already familiar and willing to donate some time. Such a person could probably whip some out fairly quickly. 3. We need a few smoke tests that try to resize an existing root as well 4. We need buyoff from Wido Den Hollander that the RBD support looks good 5. We need buyoff from Mike Tutowski that he either supports it or fails gracefully 6. We need to see if any of the other hypervisor devs want to implement the feature for their hypervisor. Basically they just need to look at the VolumeObjectTO's size when CopyCommand is passed to their hypervisor plugin and do something with it, rather than assuming the template's size. 7. We need to iron out the API details parameter, since any tests written or UI changes will rely on it. Currently it works as 'details[0].rootdisksize=3', which was implemented earlier by Bharat (see other email thread), but that seems incorrect. Per other maps the API should be "details[0].key=rootdisksize,details[0].value=3". 8. Finally, get UI support added in (not necessary, but would be nice). was (Author: mlsorensen): Ok, I've got initial support for passing rootdisksize parameter in that branch. It works for local, NFS, and CLVM on KVM. I implemented RBD but have not tested. Before I can request merge, a few things need to happen, that I'm wondering if you can act as follow-up guy for, since I may or may not have time to do so. 1. Someone else needs to run some tests and verify the work, and perhaps we need to fix a few things as they come up. 2. We need a few smoke tests written that try the rootdisksize parameter and verify they work with KVM and fail with other hypervisors. I'm not really up to speed on the current testing infra and this might take me awhile if we can't find someone who is already familiar and willing to donate some time. Such a person could probably whip some out fairly quickly. 3. We need a few smoke tests that try to resize an existing root as well 4. We need buyoff from Wido Den Hollander that the RBD support looks good 5. We need buyoff from Mike Tutowski that he either supports it or fails gracefully 6. We need to iron out the API details parameter, since any tests written or UI changes will rely on it. Currently it works as 'details[0].rootdisksize=3', which was implemented earlier by Bharat (see other email thread), but that seems incorrect. Per other maps the API should be "details[0].key=rootdisksize,details[0].value=3". 7. Finally, get UI support added in (not necessary, but would be nice). > Root resize > ----------- > > Key: CLOUDSTACK-6181 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6181 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Hypervisor Controller, Storage Controller, UI > Affects Versions: 4.4.0 > Environment: KVM/libvirt/CentOS, Xenserver > Reporter: Nux > Labels: disk, resize, template > Fix For: 4.4.0 > > > Rationale: > Currently the root size of an instance is locked to that of the template. > This creates unnecessary template duplicates, prevents the creation of a > market place, wastes time and disk space and generally makes work more > complicated. > Real life example - a small VPS provider might want to offer the following > sizes (in GB): > 10,20,40,80,160,240,320,480,620 > That's 9 offerings. > The template selection could look like this, including real disk space used: > Windows 2008 ~10GB > Windows 2008+Plesk ~15GB > Windows 2008+MSSQL ~15GB > Windows 2012 ~10GB > Windows 2012+Plesk ~15GB > Windows 2012+MSSQL ~15GB > CentOS ~1GB > CentOS+CPanel ~3GB > CentOS+Virtualmin ~3GB > CentOS+Zimbra ~3GB > CentOS+Docker ~2GB > Debian ~1GB > Ubuntu LTS ~1GB > In this case the total disk space used by templates will be 828 GB, that's > almost 1 TB. If your storage is expensive and limited SSD this can get > painful! > If the root resize feature is enabled we can reduce this to under 100 GB. -- This message was sent by Atlassian JIRA (v6.2#6252)