[
https://issues.apache.org/jira/browse/CLOUDSTACK-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919219#comment-13919219
]
Mandar Barve commented on CLOUDSTACK-5583:
------------------------------------------
Hi,
I tried to reproduce the issue but couldn't get this to fail for
insufficient space. I then injected an exception trying to list files from a
non existent path (added this code in the "try" block). This landed me into the
exception handling code. It raised correct exception saying "file not found"
which was captured in the management server vmops log file. It was not
displayed by the GUI. GUI just reported Error. The plugin code returns "0"
immediately after the line of code that raises exception but I think this
applies only for successful execution of the plugin code that reverts the
snapshot.
If any exception is raised (e.g. in the reported case here insufficient
space) then the code should return appropriate error message to the caller as I
found. In exception handling path return "0" wouldn't execute.
Can you please double check or let me know if I am missing anything?
Thanks,
Mandar
> vmopsSnapshot plug-in (XenServer) does not return an error when it should
> -------------------------------------------------------------------------
>
> Key: CLOUDSTACK-5583
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5583
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Xen
> Affects Versions: 4.3.0
> Environment: XenServer 6.1
> Reporter: Mike Tutkowski
> Fix For: 4.3.0
>
>
> I tried to revert a VM snapshot and one of my storage repositories had an
> insufficient amount of space. The plug-in did not return an error message (it
> returned "0").
> From the XenServer vmopsSnapshot plug-in's revert_memory_snapshot method:
> [root@XenServer-6 ~]# xe snapshot-revert
> snapshot-uuid=82e33f6d-59f3-a26d-4171-d51cd58716d8
> Error code: SR_BACKEND_FAILURE_44
> Error parameters: , There is insufficient space,
> An error should be returned from the plug-in instead of "0".
--
This message was sent by Atlassian JIRA
(v6.2#6252)
