[ https://issues.apache.org/jira/browse/CLOUDSTACK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosk Kelkar reassigned CLOUDSTACK-7044: ------------------------------------------- Assignee: Ashutosk Kelkar > [Automation] Remove "getPortableIpRangeServices" from common.py and move > portableIpRange information to test_data.py > -------------------------------------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-7044 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7044 > Project: CloudStack > Issue Type: Test > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation, Test > Affects Versions: 4.5.0 > Reporter: Chandan Purushothama > Assignee: Ashutosk Kelkar > Fix For: 4.5.0 > > > We do not have cloudstack config files present in the code. Hence anyone new > who wants to run the test_portable_ip.py test cases do not have any > information about what needs to be provided in the config file for the tests > execution. Pushing such data to test_data.py gives an idea about what data > should be used. > Kindly remove the below method from common.py and add the data to > test_data.py. Please remove the method references from test_portable_ip.py > too. > def getPortableIpRangeServices(config): > """ Reads config values related to portable ip and fills up > services accordingly""" > services = {} > attributeError = False > if config.portableIpRange.startip: > services["startip"] = config.portableIpRange.startip > else: > attributeError = True > if config.portableIpRange.endip: > services["endip"] = config.portableIpRange.endip > else: > attributeError = True > if config.portableIpRange.netmask: > services["netmask"] = config.portableIpRange.netmask > else: > attributeError = True > if config.portableIpRange.gateway: > services["gateway"] = config.portableIpRange.gateway > else: > attributeError = True > if config.portableIpRange.vlan: > services["vlan"] = config.portableIpRange.vlan > if attributeError: > services = FAILED > return services -- This message was sent by Atlassian JIRA (v6.2#6252)