[ https://issues.apache.org/jira/browse/CLOUDSTACK-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Animesh Chaturvedi updated CLOUDSTACK-7031: ------------------------------------------- Assignee: Santhosh Kumar Edukulla > [Automation] deployDataCenter.py issues > --------------------------------------- > > Key: CLOUDSTACK-7031 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7031 > Project: CloudStack > Issue Type: Test > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation > Affects Versions: 4.4.0 > Reporter: Alex Brett > Assignee: Santhosh Kumar Edukulla > Fix For: 4.4.0 > > > In Marvin's deployDataCenter.py on master and 4.4-forward, some functions > within the DeployDataCenters class call sys.exit(1) directly. Good practise > is for sys.exit to only ever be called from inside a __main__ environment, > and not from within a class. > In particular, if using the deployDataCenter.py code as a library rather than > invoking it directly, this can result in unexpected application exits if a > problem occurs. > In addition, when run directly deployDataCenter.py will always exit with > error code 1, even after a successful deploy, which is not helpful to anybody > wanting to script the code. > I've prepared a patch against 4.4-forward that resolves these issues (and > also tidies up logging by removing calls to print from inside the > DeployDataCenters class), which I'll submit for review. I can't assign this > ticket to myself however... -- This message was sent by Atlassian JIRA (v6.2#6252)