[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128276#comment-14128276
 ] 

ASF subversion and git services commented on CLOUDSTACK-7528:
-------------------------------------------------------------

Commit 91fd8d7cd5d5a83bf75f5f2972ad2eb2a4a07694 in cloudstack's branch 
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91fd8d7 ]

CLOUDSTACK-7528: More verbose logging when sending alert fails

When sendAlert is called on an AlertManager impl, if it fails it logs that
something was wrong but does not log the body of the issue/error. This means
we tell the user/admin that there was an issue but don't share the "issue"
with them at all as the email alert fail (or that they were not initialized).

Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com>
(cherry picked from commit 885c02dbd8b40d654f4a84fca8474ff88bc7ca5e)
Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com>

Conflicts:
        server/src/com/cloud/alert/AlertManagerImpl.java
        usage/src/com/cloud/usage/UsageAlertManagerImpl.java


> When AlertManager fails to sendAlert it does not log the actual issue/error
> ---------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7528
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7528
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.2.0, 4.2.1, 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Critical
>             Fix For: 4.5.0, 4.3.1, 4.4.1
>
>
> AlertManager has a sendAlert method, the impls try to send emailAlerts but if 
> they fail they log it as warning the subject/error but don't log the actual 
> error. This message in logs is useless for users/admins as we tell them that 
> there is an issue but don't share with them at all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to