Anshul Gangwar created CLOUDSTACK-7931:
------------------------------------------

             Summary: Setting Null for global network throttling params doesn't 
trigger suitable error, fails silently
                 Key: CLOUDSTACK-7931
                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7931
             Project: CloudStack
          Issue Type: Bug
      Security Level: Public (Anyone can view this level - this is the default.)
            Reporter: Anshul Gangwar
            Assignee: Anshul Gangwar
            Priority: Critical




Set global configs network.throttling.rate and vm.network.throttling.rate to 
NULL value.
Then launch VM in a new network

Result
=====
VM fails to launch but it fails without any ERROR logs or suitable exceptions.
A corresponding INFO log seems to have nothing but "null"

Generally, for few global configs NULL is an acceptable value in some cases. If 
this is not the case, then we should not allow to set such a value for the 
config. The API should error out suitably. This is one issue.

Further, it should throw an appropriate error when the deploy VM fails to 
design network. The error in this case is not handled suitably and there's 
nothing in ERROR logs as well.

Looking at the below logs, it's impossible to figure out the reason for the 
failure of deploy VM. So at some point, if a user inadvertently sets it to 
NULL, neither does the updateConfiguration API result in error nor does the 
deployVirtualMachine throw a suitable error.

Here's the log:

2014-11-13 13:29:15,584 DEBUG [c.c.a.ApiServlet] 
(catalina-exec-18:ctx-285ce7d9) ===START=== 10.144.7.5 – GET 
command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789
2014-11-13 13:29:15,617 DEBUG [o.a.c.n.c.m.ContrailGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
2014-11-13 13:29:15,617 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) design called
2014-11-13 13:29:15,618 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network, 
the physical isolation type is not MIDO
2014-11-13 13:29:15,619 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
2014-11-13 13:29:15,620 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
2014-11-13 13:29:15,621 DEBUG [c.c.n.g.OvsGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
2014-11-13 13:29:15,644 DEBUG [o.a.c.n.g.SspGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) SSP not configured to be active
2014-11-13 13:29:15,645 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
2014-11-13 13:29:15,646 DEBUG [c.c.n.g.NuageVspGuestNetworkGuru] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
2014-11-13 13:29:15,648 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
(catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Releasing lock for 
Acct[467a4f66-698f-11e4-be18-42407779c24b-admin]
2014-11-13 13:29:15,688 DEBUG [c.c.a.ApiServlet] (catalina-exec-18:ctx-285ce7d9 
ctx-5245ccb7) ===END=== 10.144.7.5 – GET 
command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789
2014-11-13 13:29:15,727 DEBUG [c.c.a.ApiServlet] (catalina-exec-9:ctx-54781545) 
===START=== 10.144.7.5 – GET 
command=deployVirtualMachine&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&zoneid=b642a92a-3480-4818-99bf-6546a28df624&templateid=f7df5ef0-698e-11e4-be18-42407779c24b&hypervisor=XenServer&serviceofferingid=04840780-04d0-4b41-847a-dda08ad460f4&iptonetworklist%5B0%5D.networkid=c0e24f7a-fe03-4a3b-a11e-ab29150b803b&displayname=throttlingvm1&name=throttlingvm1&_=1415866216945
2014-11-13 13:29:15,753 DEBUG [c.c.n.NetworkModelImpl] 
(catalina-exec-9:ctx-54781545 ctx-e87f4810) Service SecurityGroup is not 
supported in the network id=209
2014-11-13 13:29:15,777 DEBUG [c.c.v.UserVmManagerImpl] 
(catalina-exec-9:ctx-54781545 ctx-e87f4810) Allocating in the DB for vm
2014-11-13 13:29:15,793 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(catalina-exec-9:ctx-54781545 ctx-e87f4810) Allocating entries for VM: 
VM[User|i-2-22-VM]
2014-11-13 13:29:15,794 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(catalina-exec-9:ctx-54781545 ctx-e87f4810) Allocating nics for 
VM[User|i-2-22-VM]
2014-11-13 13:29:15,794 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
(catalina-exec-9:ctx-54781545 ctx-e87f4810) Allocating nic for vm 
VM[User|i-2-22-VM] in network Ntwk[209|Guest|8] with requested profile 
NicProfile[0-0-null-null-null
2014-11-13 13:29:15,808 DEBUG [c.c.u.d.T.Transaction] 
(catalina-exec-9:ctx-54781545 ctx-e87f4810) Rolling back the transaction: Time 
= 41 Name = catalina-exec-9; called by 
-TransactionLegacy.rollback:902-TransactionLegacy.removeUpTo:845-TransactionLegacy.close:669-Transaction.execute:49-NetworkOrchestrator.allocate:711-VirtualMachineManagerImpl$1.doInTransactionWithoutResult:396-TransactionCallbackWithExceptionNoReturn.doInTransaction:25-TransactionCallbackWithExceptionNoReturn.doInTransaction:21-Transaction.execute:45-VirtualMachineManagerImpl.allocate:388-CloudOrchestrator.createVirtualMachine:236-UserVmManagerImpl$3.doInTransaction:3119
2014-11-13 13:29:15,817 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-3:null) SeqA 2-28534: Processing Seq 2-28534: { Cmd , 
MgmtId: -1, via: 2, Ver: v1, Flags: 11, 
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":1,"_loadInfo":"
{\n \"connections\": []\n}

","wait":0}}] }
2014-11-13 13:29:15,819 INFO [c.c.a.ApiServer] (catalina-exec-9:ctx-54781545 
ctx-e87f4810) null
2014-11-13 13:29:15,821 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-3:null) SeqA 2-28534: Sending Seq 2-28534: { Ans: , 
MgmtId: 72844649808459, via: 2, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":true,"wait":0}}] }
2014-11-13 13:29:15,822 DEBUG [c.c.a.ApiServlet] (catalina-exec-9:ctx-54781545 
ctx-e87f4810) ===END=== 10.144.7.5 – GET 
command=deployVirtualMachine&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&zoneid=b642a92a-3480-4818-99bf-6546a28df624&templateid=f7df5ef0-698e-11e4-be18-42407779c24b&hypervisor=XenServer&serviceofferingid=04840780-04d0-4b41-847a-dda08ad460f4&iptonetworklist%5B0%5D.networkid=c0e24f7a-fe03-4a3b-a11e-ab29150b803b&displayname=throttlingvm1&name=throttlingvm1&_=1415866216945
2014-11-13 13:29:20,818 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-4:null) SeqA 2-28535: Processing Seq 2-28535: { Cmd , 
MgmtId: -1, via: 2, Ver: v1, Flags: 11, 
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":1,"_loadInfo":"
{\n \"connections\": []\n}

","wait":0}}] }
2014-11-13 13:29:20,823 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-4:null) SeqA 2-28535: Sending Seq 2-28535: { Ans: , 
MgmtId: 72844649808459, via: 2, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":true,"wait":0}}] }
2014-11-13 13:29:25,159 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-632a5f21) Running Capacity Checker ...
2014-11-13 13:29:25,159 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-632a5f21) recalculating system capacity
2014-11-13 13:29:25,159 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-632a5f21) Executing cpu/ram capacity update
2014-11-13 13:29:25,170 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) Found 2 VMs on host 1
2014-11-13 13:29:25,173 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) Found 0 VM, not running on host 1
2014-11-13 13:29:25,174 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) No need to calibrate cpu capacity, host:1 
usedCpu: 1000 reservedCpu: 0
2014-11-13 13:29:25,174 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) No need to calibrate memory capacity, host:1 
usedMem: 1610612736 reservedMem: 0
2014-11-13 13:29:25,188 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) Found 2 VMs on host 4
2014-11-13 13:29:25,194 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) Found 0 VM, not running on host 4
2014-11-13 13:29:25,196 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) No need to calibrate cpu capacity, host:4 
usedCpu: 4500 reservedCpu: 0
2014-11-13 13:29:25,196 DEBUG [c.c.c.CapacityManagerImpl] 
(CapacityChecker:ctx-632a5f21) No need to calibrate memory capacity, host:4 
usedMem: 1610612736 reservedMem: 0
2014-11-13 13:29:25,201 DEBUG [c.c.d.DeploymentPlanningManagerImpl] 
(HostReservationReleaseChecker:ctx-d94e4eee) Checking if any host reservation 
can be released ...
2014-11-13 13:29:25,204 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] 
(AsyncJobMgr-Heartbeat-1:ctx-ad293aec) Begin cleanup expired async-jobs
2014-11-13 13:29:25,229 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-632a5f21) Done executing cpu/ram capacity update
2014-11-13 13:29:25,229 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-632a5f21) Executing storage capacity update




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to