[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-5110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajani Karuturi updated CLOUDSTACK-5110:
----------------------------------------
    Fix Version/s:     (was: 4.2.1)
                   4.3.2

> [Automation] Hardcoded value need to remove from test_guest_vlan_range.py
> -------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-5110
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5110
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Automation, marvin
>    Affects Versions: 4.2.1
>         Environment: Automation
>            Reporter: Rayees Namathponnan
>             Fix For: 4.3.2
>
>
> There are many test cases in both smoke and intergration suite with hard 
> coded values, that need be removed; 
> see test_guest_vlan_range.py, vlan range is hard coded here
>   30 class Services:
>   31     """Test Dedicating Guest Vlan Ranges
>   32     """
>   33 
>   34     def __init__(self):
>   35         self.services = {
>   36                         "domain": {
>   37                                    "name": "Domain",
>   38                                    },
>   39                         "account": {
>   40                                     "email": "t...@test.com",
>   41                                     "firstname": "Test",
>   42                                     "lastname": "User",
>   43                                     "username": "test",
>   44                                     "password": "password",
>   45                          },
>   46                         "name": "testphysicalnetwork",
>   47 
>   48                         "vlan": "2118-2120",
>   49                     }
>  Suggestion,
> we need to setup property file, and test case should read from this 
> example, inside the  we should define variable like this
> integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange. 
> vlan=2118-2120
> integration.smoke.test_primary_storage.TestPrimaryStorageServices. nfs.url



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to