[ https://issues.apache.org/jira/browse/CLOUDSTACK-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552008#comment-14552008 ]
ASF GitHub Bot commented on CLOUDSTACK-8486: -------------------------------------------- Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/266#issuecomment-103812423 LGTM, thanks @wilderrodrigues loved the reports :) > Refactoring LibVirt (KVM) Hypervisor Plugin > ------------------------------------------- > > Key: CLOUDSTACK-8486 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8486 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM > Affects Versions: 4.5.0 > Reporter: Wilder Rodrigues > Assignee: Wilder Rodrigues > Fix For: 4.6.0 > > > The main goal behind this refactor is to reduce the amount of code in the > LibvirtComputingResource class and also all the nested IFs that it has in the > executeRequest() method (67 in total). > The same approach used in the CitrixResourceBase refactoring will be applied > here. > In addition, for each method extracted from the LibvirtComputingResource into > a wrapper, a unit test will be created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)