[
https://issues.apache.org/jira/browse/CLOUDSTACK-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555650#comment-14555650
]
ASF GitHub Bot commented on CLOUDSTACK-8487:
--------------------------------------------
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/268#issuecomment-104535446
Posting review here as I am not able to put inline review comments.
Comments in the format (line number space comment)
133 space between self,vm
147 There should not be space between parameter=value
133 Function name should resemble an order given to function, like doThis,
doThat. change name to createVmSnapshotForDataIntegrityCheck or something
suitable
133 Are we not actually checking integrity or only creating Vm snapshot?
164 space between parameters. You can do this automatically using autopep8
tool. pip install autopep8. autopep8 -i -a -a fileName.py. And then check if
any pep8 issues are not fixed automatically by pep8 fileName.py and fix them
manually.
2480 If test restarts management server by default, then move it to maint
folder. Or you can use key "restartManagementServerThroughTestCase"
912 use self.skipTest("") instead of raise unittest.SkipTest, change all
such instances
1235 Check if destinationHost is returned as None, in that migrate should
not be performed, change everywhere applicable
1278 Compare string after converting to lowercase only. Also don't use
string directly, make use of constant strings from codes.py file, change
everywhere applicable
Also, post the marvin run logs showing test cases passed successfully.
> Add VMware vMotion Tests
> ------------------------
>
> Key: CLOUDSTACK-8487
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8487
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation
> Environment: Hypervisor :VMware
> Storage type : VMFS, NFS
> Storage scope : clusterwide, local, zonewide
> VM : Linux and Windows
> Reporter: Abhinav Roy
> Assignee: Abhinav Roy
> Fix For: 4.6.0
>
>
> Adding a new test script testpath_vMotion_vmware.py in the
> test/integration/testpath folder.
> This script has vMotion related test cases for VMware.
> Tests include :
> ------------------------
> 1. Migrate VM with volume within/across the cluster both for vmfs and nfs
> datastores, windows and linux vms.
> 2. Migrate VM with volume within/across cluster for local storage.
> 3. Migrate across cwps and zwps.
> 4. Migrate across nfs and vmfs.
> 5. Negative scenarios
> 6. Migration tests when host is put in maintenance.
> 7. Migration tests when storage is put in maintenance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
