[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556133#comment-14556133
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8243:
--------------------------------------------

GitHub user bhaisaab opened a pull request:

    https://github.com/apache/cloudstack/pull/286

    CLOUDSTACK-8243: KVM agent should not use hardcoded string tails

    For KVM agent, guid is configurable in agent.properties, this fix allows the
    configuration to work by removing string tail (the 
-LibvirtComputingResource suffix)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/cloudstack CLOUDSTACK-8243

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #286
    
----
commit 6753beefebc9f839e817c0192b75df22fd6a2506
Author: Rohit Yadav <[email protected]>
Date:   2015-05-22T13:21:36Z

    CLOUDSTACK-8243: KVM agent should not use hardcoded string tails
    
    For KVM agent, guid is configurable in agent.properties, this fix allows the
    configuration to work by removing string tail (the 
-LibvirtComputingResource suffix).
    
    Signed-off-by: Rohit Yadav <[email protected]>

----


> LibvirtServerDiscoverer.java has hard coded agent class
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-8243
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8243
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.3.0
>            Reporter: Marcus Sorensen
>            Assignee: Marcus Sorensen
>             Fix For: 4.5.2
>
>
> LibvirtServerDiscoverer.java has a hard-coded string-based reference to 
> LibvirtComputingResource:
> String guidWithTail = guid + "-LibvirtComputingResource";
> However, this class is configurable in the agent via agent.properties, and 
> this breaks the configurability. This needs to be reworked ideally to 
> discover agents regardless of what the suffix of the guid is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to