[
https://issues.apache.org/jira/browse/CLOUDSTACK-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556832#comment-14556832
]
ASF GitHub Bot commented on CLOUDSTACK-8502:
--------------------------------------------
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/280#issuecomment-104771495
@wilderrodrigues the Xenserver tests are failing in master with a ClassCast
Exception :(
*/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/citrix/CitrixRequestWrapper.java*
` Reflections baseWrappers = new
Reflections("com.cloud.hypervisor.xenserver.resource.wrapper");
@SuppressWarnings("rawtypes")
Set<Class<? extends CommandWrapper>> baseSet =
baseWrappers.getSubTypesOf(CommandWrapper.class);`
The baseSet ends up becoming the sum of all tests, because the scanner is
recursive, so wrapper.xen56, wrapper.xcp, etc will all get included in the set.
I've tested fixing it by changing the package for the Citrix* classes to a
package that in not parent to the other wrapper's classes and it's working fine.
Do you want to fix this your way, or should I send a PR? :)
> Implement Annotions for XenServer and Libvirt resources
> -------------------------------------------------------
>
> Key: CLOUDSTACK-8502
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8502
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Priority: Minor
> Fix For: 4.6.0
>
>
> The way the refactoring of the XenServer and Libvirt resources was done
> helped a lot to increase maintainability, compared to what it was before:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Refactoring+XenServer+Hypervisor+Plugin
> However, in order to make sure we don need to change the
> LibvirtRequestWrapper or CitrixRequestWrapper ever, we are now using
> annotation on the CommandWrapper implementations.
> The documentation will be updated in order to depict the Annotations design.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
