[ https://issues.apache.org/jira/browse/CLOUDSTACK-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611864#comment-14611864 ]
ASF GitHub Bot commented on CLOUDSTACK-8590: -------------------------------------------- Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/546#issuecomment-118011859 @remibergsma and @karuturi You are right. I believe both @bhaisaab and I forgot that. Once he said "go ahead with the merge" I just merged the thing. Apologies. Cheers, Wilder > Refactoring NiciraNVP resource > ------------------------------ > > Key: CLOUDSTACK-8590 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8590 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller > Reporter: Wilder Rodrigues > Assignee: Wilder Rodrigues > Fix For: 4.6.0 > > > Apply the same technique that was used for the refactoring of the Libvirt and > XenServer hypervisors. > All the commands will be wrapped by a ResourceWrapper annotated class. This > will reduce the amount of private methods in the NiciraNvpResource class and > also increase its testability, maintainability, extensibility and > readability -- This message was sent by Atlassian JIRA (v6.3.4#6332)