[
https://issues.apache.org/jira/browse/CLOUDSTACK-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626285#comment-14626285
]
ASF GitHub Bot commented on CLOUDSTACK-8634:
--------------------------------------------
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/586
CLOUDSTACK-8634: Made changes to test_security_group.py test suite to
support EIP
Made changes to test_security_group.py test suite to support EIP
1. In case of a basic zone with EIP/ELB capability vm will have two ip
addresses one from public ip range and another one from guest ip range.
vm creation method in base.py returns vm ip address which is part of guest
ip range as the vm.ssh.ipaddress if we don't pass mode to it. So access to vms
with that ip address would not be successful. Made changes to handle this
2.vm public address is associated with Netscaler. So even if we don't allow
ping traffic in security groups applied to vm, ping will be successful.
Skipping ping test in case the zone is enabled with EIP/ELB
3.Removing default rules from security groups except what is needed for
that test.
Test Results:
==========
Test ingress rules for specific IP set ... === TestName:
test_ingress_rules_specific_IP_set | Status : SUCCESS ===
ok
Test revoke ingress rule ... === TestName: test_01_revokeIngressRule |
Status : SUCCESS ===
ok
Test ingress rules for specific IP set and non default security group ...
=== TestName: test_ingress_rules_specific_IP_set_non_def_sec_group | Status :
SUCCESS ===
ok
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanju1010/cloudstack eip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/586.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #586
----
commit 3ecf3dc172cc5f60f55d9b389d3e53a6a1e67f05
Author: sanjeev <sanj...@apache.org>
Date: 2015-07-14T11:54:58Z
CLOUDSTACK-8634: Made changes to test_security_group.py test suite to
support EIP
----
> Make changes to test_security_group.py test suite to support EIP
> ----------------------------------------------------------------
>
> Key: CLOUDSTACK-8634
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8634
> Project: CloudStack
> Issue Type: Test
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Sanjeev N
> Assignee: Sanjeev N
>
> Make changes to test_security_group.py test suite to support EIP
> 1. In case of a basic zone with EIP/ELB capability vm will have two ip
> addresses one from public ip range and another one from guest ip range.
> vm creation method in base.py returns vm ip address which is part of guest ip
> range as the vm.ssh.ipaddress if we don't pass mode to it. So access to vms
> with that ip address would not be successful. Made changes to handle this
> 2.vm public address is associated with Netscaler. So even if we don't allow
> ping traffic in security groups applied to vm, ping will be successful.
> Skipping ping test in case the zone is enabled with EIP/ELB
> 3.Removing default rules from security groups except what is needed for that
> test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
