[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647355#comment-14647355
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8687:
--------------------------------------------

Github user devdeep commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/635#discussion_r35849928
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
 ---
    @@ -60,6 +61,15 @@
                    description = "template ID of the template to be prepared 
in primary storage(s).")
         private Long templateId;
     
    +    @ACL(accessType = AccessType.OperateEntry)
    +    @Parameter(name = ApiConstants.STORAGE_ID,
    +            type = CommandType.UUID,
    +            entityType = StoragePoolResponse.class,
    +            required = false,
    +            description = "storage pool ID of the primary storage pool to 
which the template should be prepared. If it is not provided the template" +
    +                    " is prepared on all the available primary storage 
pools.")
    +    private Long storageId;
    --- End diff --
    
    @kishankavala There isn't a poolid or storagePoolid constant available in 
apiconstants. I had looked for it and couldn't find it. Moreover, storageId is 
the parameter name used through the apis whenever a primary storage pool is 
referred, for example in list/update/migrate volumes, volume response etc. So I 
decided to use storageId here too for consistency, instead of defining a new 
one.


> Update prepare template api to seed/prepare a template only on a give primary 
> storage
> -------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8687
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8687
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Devdeep Singh
>            Assignee: Devdeep Singh
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Currently, the prepare template api will seed/prepare a given template on all 
> the primary storage pools in a zone. If however, a user wishes to prepare a 
> template only a particular storage pool, it isn't possible.
> The prepare template api should be updated to allow seedng/preparing a 
> template only on a given primary storage pool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to