[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694681#comment-14694681
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8726:
--------------------------------------------

Github user nitt10prashant commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/683#discussion_r36940905
  
    --- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
    @@ -0,0 +1,256 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +#Import Local Modules
    +from marvin.cloudstackAPI import *
    +from marvin.cloudstackTestCase import cloudstackTestCase, unittest
    +from marvin.lib.utils import (cleanup_resources,
    +                              validateList)
    +from marvin.lib.base import (ServiceOffering,
    +                             VirtualMachine,
    +                             Account,
    +                             Volume,
    +                             DiskOffering,
    +                             )
    +from marvin.lib.common import (get_domain,
    +                                get_zone,
    +                                get_template,
    +                                find_storage_pool_type)
    +from marvin.codes import (
    +    PASS,
    +    FAILED,
    +    JOB_FAILED,
    +    JOB_CANCELLED,
    +    JOB_SUCCEEDED
    +)
    +from nose.plugins.attrib import attr
    +import time
    +
    +
    +class TestMultipleVolumeAttach(cloudstackTestCase):
    +
    +    @classmethod
    +    def setUpClass(cls):
    +        testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
    +        cls.apiclient = testClient.getApiClient()
    +        cls.services = testClient.getParsedTestDataConfig()
    +        cls._cleanup = []
    +        # Get Zone, Domain and templates
    +        cls.domain = get_domain(cls.apiclient)
    +        cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
    +        cls.services['mode'] = cls.zone.networktype
    +        cls.hypervisor = testClient.getHypervisorInfo()
    +        cls.invalidStoragePoolType = False
    +        #for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
    +        if cls.hypervisor.lower() == 'lxc':
    +            if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
    +                # RBD storage type is required for data volumes for LXC
    +                cls.invalidStoragePoolType = True
    +                return
    +        cls.disk_offering = DiskOffering.create(
    +                                    cls.apiclient,
    +                                    cls.services["disk_offering"]
    +                                    )
    +
    +        template = get_template(
    +                            cls.apiclient,
    +                            cls.zone.id,
    +                            cls.services["ostype"]
    +                            )
    +        if template == FAILED:
    +            assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
    +
    +        cls.services["domainid"] = cls.domain.id
    +        cls.services["zoneid"] = cls.zone.id
    +        cls.services["template"] = template.id
    +        cls.services["diskofferingid"] = cls.disk_offering.id
    +
    +        # Create VMs, VMs etc
    +        cls.account = Account.create(
    +                            cls.apiclient,
    +                            cls.services["account"],
    +                            domainid=cls.domain.id
    +                            )
    +        cls.service_offering = ServiceOffering.create(
    +                                            cls.apiclient,
    +                                            
cls.services["service_offering"]
    +                                        )
    +        cls.virtual_machine = VirtualMachine.create(
    +                                    cls.apiclient,
    +                                    cls.services,
    +                                    accountid=cls.account.name,
    +                                    domainid=cls.account.domainid,
    +                                    
serviceofferingid=cls.service_offering.id,
    +                                    mode=cls.services["mode"]
    +                                )
    +
    +        if cls.hypervisor.lower() == 'lxc' and 
cls.storage_pools.type.lower() != 'rbd':
    --- End diff --
    
    it think it is better to deiced if you want to skip as early as possible.
    in this case it will be good to skip test cases before deploy vm /create 
acc /service off


> Automation for Quickly attaching multiple data disks to a new VM
> ----------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8726
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8726
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.6.0
>            Reporter: Pavan Kumar Bandarupally
>            Assignee: Pavan Kumar Bandarupally
>             Fix For: 4.6.0
>
>
> When trying to attach multiple data disks to a VM in quick succession, 
> Cloudstack Synchronizes the tasks of disk preparation and reconfiguration of 
> a VM with the disk.
> This script automates the attach operation and verifies that the attach 
> operation is successfully completed without any issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to