[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696752#comment-14696752
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8669:
--------------------------------------------

GitHub user karuturi opened a pull request:

    https://github.com/apache/cloudstack/pull/695

    CLOUDSTACK-8669: create volume failed due to null charset

    Added a new private method getCharSetFromConnection() which checks if
    the connection charset is null and if it is null, returns
    StringUtils.getPreferredCharset
    
    regression caused by commit f03411ca0436c8b52f5e60b0c8820fd1d1ba2ff6

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8669

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #695
    
----
commit a65339ff1bc99f35fb206f787167ebc98940a829
Author: Rajani Karuturi <rajanikarut...@gmail.com>
Date:   2015-08-13T12:09:44Z

    CLOUDSTACK-8669: making StringUtils.getDefaultCharset protected
    
    made this protected as its only use is in the Test file.

commit 1dcc5aa7dfaa9e9b3b7f912e1d50fcce41190a3f
Author: Rajani Karuturi <rajanikarut...@gmail.com>
Date:   2015-08-13T12:22:51Z

    CLOUDSTACK-8669: create volume failed due to null charset
    
    Added a new private method getCharSetFromConnection() which checks if
    the connection charset is null and if it is null, returns
    StringUtils.getPreferredCharset
    
    regression caused by commit f03411ca0436c8b52f5e60b0c8820fd1d1ba2ff6

----


> [VMWare] create volume failed due to Exception: 
> java.lang.NullPointerException Message: charsetName
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8669
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8669
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Volumes
>    Affects Versions: 4.6.0
>         Environment: Latest build from ACS master with commit 
> 2984acca83fff03c2ad8bdd28c097e797d4ce087 
> Hypervisor: VMWares
>            Reporter: Sanjeev N
>            Assignee: Rajani Karuturi
>            Priority: Critical
>         Attachments: management-server.zip
>
>
> [VMWare] create volume failed due to Exception: 
> java.lang.NullPointerException Message: charsetName
> Steps to reproduce:
> ================
> 1.Bring up CS in advanced zone with vmware cluster
> 2.Deploy one guest vm using default cent os template
> 3.Create one data disk with shared disk offering
> 4.Attach the data disk to the vm created in step 2
> Result:
> =====
> Attach volume failed with NPE:
> 2015-07-23 16:06:58,103 ERROR [c.c.s.r.VmwareStorageProcessor] 
> (DirectAgent-64:ctx-6becb596 10.81.28.111, job-48/job-49, cmd: 
> CreateObjectCommand) create volume failed due to Exception: 
> java.lang.NullPointerException
> Message: charsetName
> java.lang.NullPointerException: charsetName
>         at java.io.InputStreamReader.&lt;init&gt;(InputStreamReader.java:99)
>         at 
> com.cloud.hypervisor.vmware.util.VmwareContext.uploadResourceContent(VmwareContext.java:486)
>         at 
> com.cloud.hypervisor.vmware.mo.VirtualMachineMO.detachDisk(VirtualMachineMO.java:1217)
>         at 
> com.cloud.storage.resource.VmwareStorageProcessor.createVolume(VmwareStorageProcessor.java:1545)
>         at 
> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:113)
>         at 
> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:56)
>         at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:470)
>         at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:302)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
>         at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>         at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:166)
>         at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
>         at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
>         at java.lang.Thread.run(Thread.java:722)
> 2015-07-23 16:06:58,104 DEBUG [c.c.a.m.DirectAgentAttache] 
> (DirectAgent-64:ctx-6becb596) Seq 2-8089027880710832216: Response Received:
> 2015-07-23 16:06:58,104 DEBUG [c.c.a.t.Request] (DirectAgent-64:ctx-6becb596) 
> Seq 2-8089027880710832216: Processing:  { Ans: , MgmtId: 187822473365406, 
> via: 2, Ver: v1, Flags: 10, 
> [{"org.apache.cloudstack.storage.command.CreateObjectAnswer":{"result":false,"details":"java.lang.NullPointerException:
>  charsetName","wait":0}}] }
> 2015-07-23 16:06:58,105 DEBUG [c.c.a.t.Request] 
> (Work-Job-Executor-10:ctx-d0586dc9 job-48/job-49 ctx-7737cd68) Seq 
> 2-8089027880710832216: Received:  { Ans: , MgmtId: 187822473365406, via: 2, 
> Ver: v1, Flags: 10, { CreateObjectAnswer } }
> 2015-07-23 16:06:58,112 WARN  [o.a.c.s.d.ObjectInDataStoreManagerImpl] 
> (Work-Job-Executor-10:ctx-d0586dc9 job-48/job-49 ctx-7737cd68) Unsupported 
> data object (VOLUME, 
> org.apache.cloudstack.storage.datastore.PrimaryDataStoreImpl@58dd2323), no 
> need to delete from object in store ref table
> Please look for job-48 in the attached Management server log file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to