[ https://issues.apache.org/jira/browse/CLOUDSTACK-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699472#comment-14699472 ]
ASF GitHub Bot commented on CLOUDSTACK-8721: -------------------------------------------- Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37183139 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName() { return instanceName; } - public Map getDetails() { + public Map<String, String> getDetails() { --- End diff -- come to think of it ``` public Map<String, String> getDetails() { return details; } ``` should even do > Setting details of VM through API results in removal of all other details > except the one passed in API > ------------------------------------------------------------------------------------------------------ > > Key: CLOUDSTACK-8721 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8721 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Anshul Gangwar > Assignee: Anshul Gangwar > > Setting details of VM through API results in removal of all other details > except the one passed in API. We are storing vm details which are not set by > user and in this process of setting details all details are getting lost > which could lead to other issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)