[ https://issues.apache.org/jira/browse/CLOUDSTACK-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728086#comment-14728086 ]
ASF GitHub Bot commented on CLOUDSTACK-8727: -------------------------------------------- Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-137254065 so now we are back to, "I would like to see two unit tests for checkForKeyByPublicKey. The succes and the failure cases. I am not sure if this check shows a very good pattern but that is out of scope for this PR. Other then unit tests missing, LGTM." I won't stop stop this with a :-1: but I think it can be augmented with more tests. > API call listVirtualMachines returns same keypair > ------------------------------------------------- > > Key: CLOUDSTACK-8727 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8727 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Kshitij Kansal > > If you register 2 SSH keypairs with the same public key then > listVirtualMachines API call will only return the first keypair. Although its > a very rare case and generally don't make much sense by registering the same > key with different name, still it can be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)