[
https://issues.apache.org/jira/browse/CLOUDSTACK-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731903#comment-14731903
]
ASF GitHub Bot commented on CLOUDSTACK-8759:
--------------------------------------------
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/773#issuecomment-137937224
LGTM Tested with two VPCs, each with a VM and created VPN between them.
Then destroyed one router, and stop/started one VM to trigger the recreation of
the VPC. That worked, and it came up with the correct nics:
```
root@r-7-VM:~# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 16436 qdisc noqueue state UNKNOWN
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state
UP qlen 1000
link/ether 0e:00:a9:fe:00:05 brd ff:ff:ff:ff:ff:ff
inet 169.254.0.5/16 brd 169.254.255.255 scope global eth0
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state
UP qlen 1000
link/ether 06:7c:92:00:00:17 brd ff:ff:ff:ff:ff:ff
inet 192.168.23.23/24 brd 192.168.23.255 scope global eth1
4: eth2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state
UP qlen 1000
link/ether 02:00:22:cf:00:03 brd ff:ff:ff:ff:ff:ff
inet 10.0.1.1/24 brd 10.0.1.255 scope global eth2
```
As a double check had a look at the VPN:
```
000 #2: "vpn-192.168.23.24/0x1":500 STATE_QUICK_I2 (sent QI2, IPsec SA
established); EVENT_SA_REPLACE in 2485s; newest IPSEC; eroute owner; isakmp#1;
idle; import:admin initiate
000 #2: "vpn-192.168.23.24/0x1" esp.c00d412a@192.168.23.24
esp.79aa41ed@192.168.23.23 tun.0@192.168.23.24 tun.0@192.168.23.23 ref=0
refhim=4294901761
000 #1: "vpn-192.168.23.24/0x1":500 STATE_MAIN_I4 (ISAKMP SA established);
EVENT_SA_REPLACE in 85228s; newest ISAKMP; lastdpd=-1s(seq in:0 out:0); idle;
import:admin initiate
```
Pings on their internal IPs from one VM to another across the two VPCs also
worked. The service was properly restored after a destroy and that was the main
goal. Well done @wilderrodrigues ! Also love the tests you wrote.
> Destroying VPC router results in a new unusable VPC router
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8759
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8759
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.6.0
> Environment: ACS master/4.6 with XenServer and KVM tested
> Reporter: Remi Bergsma
> Assignee: Wilder Rodrigues
> Priority: Critical
> Fix For: 4.6.0
>
>
> Deploy VPC
> Deploy VM
> This all works fine
> Shutdown, then destroy VPC
> Expected result:
> A new VPC router is deployed that has the same functionality than before, but
> with a new router instance ID.
> Experienced result:
> VPC router is unaccessible for CloudStack due to missing link-local interface:
> root@r-7-VM:~# ifconfig -a
> lo Link encap:Local Loopback
> inet addr:127.0.0.1 Mask:255.0.0.0
> UP LOOPBACK RUNNING MTU:16436 Metric:1
> RX packets:1 errors:0 dropped:0 overruns:0 frame:0
> TX packets:1 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:0
> RX bytes:93 (93.0 B) TX bytes:93 (93.0 B)
> From a first look, the command line info seems OK.
> root@r-7-VM:/etc/cloudstack# cat cmdline.json
> {
> "config": {
> "baremetalnotificationapikey":
> "pPgegDQwez17eCbRj4Wx8IwFs543rcPpF7Gavvtys_D7w1jnAoyJ4A-21H9Bf58s1ZjC4DTVrD0BHxNA3y7agA",
>
> "baremetalnotificationsecuritykey":
> "Sxv0QbIgRTH-PkeDWBsY-GYsKz2WIz9JIyWTK16mNnIPPZ-Ozo940_8d8bSEx5pHZ4rEdxG5HQMRRcchANHuHg",
>
> "disable_rp_filter": "true",
> "dns1": "8.8.8.8",
> "domain": "cs2cloud",
> "eth1ip": "169.254.0.249",
> "eth1mask": "255.255.0.0",
> "host": "192.168.22.61",
> "name": "r-7-VM",
> "port": "8080",
> "redundant_router": "false",
> "template": "domP",
> "type": "vpcrouter",
> "vpccidr": "10.0.1.0/24"
> },
> "id": "cmdline"
> [~wilder.rodrigues] Let's have a look when you're back!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
