[
https://issues.apache.org/jira/browse/CLOUDSTACK-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734584#comment-14734584
]
ASF GitHub Bot commented on CLOUDSTACK-8821:
--------------------------------------------
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/786#discussion_r38911089
--- Diff: ui/scripts/network.js ---
@@ -1612,6 +1613,36 @@
});
}
});
+
+ if (!isConfigRulesMsgShown) {
+ isConfigRulesMsgShown =
true;
+ $.ajax({
+ url:
createURL('listNetworkOfferings'),
+ data: {
+ id:
args.context.networks[0].networkofferingid
+ },
+ dataType: 'json',
+ async: true,
+ success:
function(json) {
+ var response =
json.listnetworkofferingsresponse.networkoffering ?
+
json.listnetworkofferingsresponse.networkoffering[0] : null;
+
+ if (response !=
null) {
+ var
egressdefaultpolicy;
+
+ if
(response.egressdefaultpolicy == true) {
+
egressdefaultpolicy = 'Block';
+ } else {
+
egressdefaultpolicy = 'Allow';
+ }
+
+
cloudStack.dialog.notice({
+ message:
_l('Configure the rules to ' + egressdefaultpolicy + ' Traffic.')
--- End diff --
Would be great if you can use a localization key from messages.properties
(by adding the sentence inside) instead of hard code message to allow the
localization of the web UI. Thanks
> Provide appropriate message in the UI when configuring the Firewall rules
> -------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8821
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8821
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: UI
> Reporter: Nitin Kumar Maharana
>
> While adding Firewall rules, the egress rules can be to configure Allow /
> Deny rules based on the Default egress policy in the network offering.
> It should provide a clear message in the UI: such as if Allow – “Configure
> the rules below to Block Traffic” – If Deny – “Configure the rules below to
> Allow Traffic”
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
