[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876604#comment-14876604
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907736
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java
---
@@ -24,12 +24,17 @@
public interface NuageVspElementClient {
- public void applyStaticNats(String networkDomainUuid, String
vpcOrSubnetUuid, boolean isL3Network, List<Map<String, Object>>
staticNatDetails) throws Exception;
+ public boolean implement(long networkId, String networkDomainUuid,
String networkUuid, String networkName, String vpcOrSubnetUuid, boolean
isL2Network, boolean isL3Network,
+ boolean isVpc, boolean isShared, String
domainTemplateName, boolean isFirewallServiceSupported, List<String>
dnsServers, List<Map<String, Object>> ingressFirewallRules,
+ List<Map<String, Object>>
egressFirewallRules, List<String> acsFipUuid, boolean egressDefaultPolicy)
throws Exception;
- public void applyAclRules(String networkUuid, String
networkDomainUuid, String vpcOrSubnetUuid, boolean isL3Network,
List<Map<String, Object>> aclRules, boolean isVpc, long networkId)
- throws Exception;
+ public void applyStaticNats(String networkDomainUuid, String
networkUuid, String vpcOrSubnetUuid, boolean isL3Network, boolean isVpc,
+ List<Map<String, Object>>
staticNatDetails) throws Exception;
- public void shutDownVpc(String domainUuid, String vpcUuid) throws
Exception;
+ public void applyAclRules(boolean isNetworkAcl, String networkUuid,
String networkDomainUuid, String vpcOrSubnetUuid, String networkName, boolean
isL2Network,
+ List<Map<String, Object>> rules, long
networkId, boolean egressDefaultPolicy, Boolean isAcsIngressAcl, boolean
networkReset, String domainTemplateName) throws Exception;
+
+ public void shutdownVpc(String domainUuid, String vpcUuid, String
domainTemplateName) throws Exception;
--- End diff --
Why is Exception declared in the throws instead of the list of expected
checked exceptions on all of these methods?
Also, ``public`` modifiers on ``public interface`` declarations are
extraneous.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
