[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935000#comment-14935000
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8901:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/880#discussion_r40658531
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -413,3 +413,6 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
       UNIQUE KEY `uk_ldap_trust_map__domain_id` (`domain_id`),
       CONSTRAINT `fk_ldap_trust_map__domain_id` FOREIGN KEY (`domain_id`) 
REFERENCES `domain` (`id`)
     ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
    +
    +INSERT IGNORE INTO `cloud`.`configuration` VALUES ('Advanced', 'DEFAULT', 
'TemplateManager', 'template.preloader.pool.size', '8', 'Size of the threadpool 
for preparetemplate api', '8', NULL, 'Global', 0);
    --- End diff --
    
    This is not required once the Configurable is implemented.


> PrepareTemplate job thread hard-coded to max 8 threads
> ------------------------------------------------------
>
>                 Key: CLOUDSTACK-8901
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8901
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: sudharma jain
>
>  The thread pool is hardcoded to use 8 threads,
> com.cloud.template.TemplateManagerImpl.configure(String, Map<String, Object>):
> _preloadExecutor = Executors.newFixedThreadPool(8, new 
> NamedThreadFactory("Template-Preloader"));
> Need to make it configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to