[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953317#comment-14953317
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41775797
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
 ---
    @@ -31,4 +31,14 @@ public TrashNetworkVspAnswer(Command command, Exception 
e) {
         public TrashNetworkVspAnswer(TrashNetworkVspCommand cmd, boolean 
success, String details) {
             super(cmd, success, details);
         }
    +
    +    @Override
    +    public boolean equals(Object obj) {
    +        return super.equals(obj);
    +    }
    +
    +    @Override
    +    public int hashCode() {
    +        return super.hashCode();
    +    }
    --- End diff --
    
    Why does this class exist?  It adds no state or behavior to the ``Answer`` 
base class.  Why not simply use ``Answer`` in this circumstance?


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for 
> this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to