[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956885#comment-14956885
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41990160
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java
---
@@ -21,24 +21,22 @@
import java.util.Collection;
import java.util.List;
-import java.util.Map;
public interface NuageVspGuruClient {
- public void implement(String networkDomainName, String
networkDomainPath, String networkDomainUuid, String networkAccountName, String
networkAccountUuid, String networkName,
- String networkCidr, String networkGateway, String networkUuid,
boolean isL3Network, String vpcName, String vpcUuid, boolean
defaultEgressPolicy,
- Collection<String> ipAddressRange) throws Exception;
+ void implement(String networkDomainName, String networkDomainPath,
String networkDomainUuid, String networkAccountName, String networkAccountUuid,
String networkName,
+ String networkCidr, String networkGateway, Long
networkAclId, List<String> dnsServers, List<String> gatewaySystemIds, boolean
isL3Network, boolean isVpc, boolean isSharedNetwork,
+ String networkUuid, String vpcName, String
vpcUuid, boolean defaultEgressPolicy, Collection<String[]> ipAddressRange,
String domainTemplateName) throws Exception;
--- End diff --
This is how the methods are declared in our client. They need to have the
same signature as defined in our client.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
