[ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975978#comment-14975978 ]
ASF GitHub Bot commented on CLOUDSTACK-8832: -------------------------------------------- Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43093404 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java --- @@ -17,28 +17,38 @@ // under the License. // -package com.cloud.agent.api.guru; - -import java.util.List; -import java.util.Map; +package com.cloud.agent.api.sync; import com.cloud.agent.api.Answer; -import com.cloud.agent.api.Command; -public class ReserveVmInterfaceVspAnswer extends Answer { +public class SyncDomainAnswer extends Answer { + + private final boolean _success; - public List<Map<String, String>> _interfaceDetails; + public SyncDomainAnswer(boolean success) { + super(); + this._success = success; + } - public ReserveVmInterfaceVspAnswer(Command cmd, List<Map<String, String>> interfaceDetails, String details) { - super(cmd, true, details); - this._interfaceDetails = interfaceDetails; + public boolean getSuccess() { + return _success; } - public ReserveVmInterfaceVspAnswer(Command cmd, Exception e) { - super(cmd, e); + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + + SyncDomainAnswer that = (SyncDomainAnswer) o; + + if (_success != that._success) return false; + + return true; } - public List<Map<String, String>> getInterfaceDetails() { - return this._interfaceDetails; + @Override + public int hashCode() { --- End diff -- Implemented <code>hashCode</code> method for the <code>Answer</code> super class, calling it from subclass. > Update Nuage VSP plugin to work with Nuage VSP release 3.2 > ---------------------------------------------------------- > > Key: CLOUDSTACK-8832 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server > Affects Versions: 4.6.0 > Reporter: Nick Livens > Assignee: Nick Livens > Attachments: nuageVspMarvinLogs.tar.gz > > > Nuage VSP 3.2 is being released, we want to bring the plugin up to date for > this release -- This message was sent by Atlassian JIRA (v6.3.4#6332)