[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010478#comment-15010478
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9065:
--------------------------------------------

Github user davidamorimfaria commented on the pull request:

    https://github.com/apache/cloudstack/pull/1075#issuecomment-157643811
  
    This is the package release version number, nothing to do with the thing 
that is packaged.
    
    Its purpose is to allow for this script to be used with an automated 
package builder, and thus create a unique package version with each iteration, 
for example using a jenkins job number instead of always being "1". Also, 
having a distinct package version makes the package directly usable in a yum 
repository without having to nuke the repodata because of signature mismatches 
for files that were rebuild using the same name (and package version).
    
    It is also not only the file name that is changed. If you instpect the repo 
you will see it in the "Release" details:
    ```
    [root@CLOUD-REPO x86_64]# rpm -qip 
cloudstack-common-4.6.0-SNAPSHOT4.el7.centos.x86_64.rpm 
    Name        : cloudstack-common
    Version     : 4.6.0
    Release     : SNAPSHOT4.el7.centos
    Architecture: x86_64
    Install Date: (not installed)
    Group       : System Environment/Libraries
    Size        : 112901174
    License     : ASL 2.0
    Signature   : (none)
    Source RPM  : cloudstack-4.6.0-SNAPSHOT4.el7.centos.src.rpm
    Build Date  : ma 16 nov 2015 19:00:45 UTC
    Build Host  : 597e5453e780
    Relocations : (not relocatable)
    Packager    : Apache CloudStack <d...@cloudstack.apache.org>
    Vendor      : Apache CloudStack <d...@cloudstack.apache.org>
    Summary     : Apache CloudStack common files and scripts
    Description :
    The Apache CloudStack files shared between agent and management server
    ```
    
    ```
    [root@CLOUD-REPO x86_64]# rpm -qip 
cloudstack-common-4.6.0-1.el7.centos.x86_64.rpm 
    Name        : cloudstack-common
    Version     : 4.6.0
    Release     : 1.el7.centos
    Architecture: x86_64
    Install Date: (not installed)
    Group       : System Environment/Libraries
    Size        : 112894853
    License     : ASL 2.0
    Signature   : (none)
    Source RPM  : cloudstack-4.6.0-1.el7.centos.src.rpm
    Build Date  : di 17 nov 2015 13:22:29 UTC
    Build Host  : dec63b100baa
    Relocations : (not relocatable)
    Packager    : Apache CloudStack <d...@cloudstack.apache.org>
    Vendor      : Apache CloudStack <d...@cloudstack.apache.org>
    Summary     : Apache CloudStack common files and scripts
    Description :
    The Apache CloudStack files shared between agent and management server
    ```


> Packaging RPM: Add option for package release version, cleanup and lint
> -----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9065
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9065
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Packaging
>    Affects Versions: 4.6.0
>            Reporter: David Amorim Faria
>            Assignee: David Amorim Faria
>            Priority: Trivial
>
> In RPM Packaging, add option for package release version.
> Also, code cleanup and some linting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to