[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021903#comment-15021903
 ] 

ASF subversion and git services commented on CLOUDSTACK-8951:
-------------------------------------------------------------

Commit 3f6d7796f1f43d1eab622f3922c1efcba68d911c in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3f6d779 ]

Merge pull request #929 from karuturi/CLOUDSTACK-8951

[4.7] CLOUDSTACK-8951: validation for config param 
"remote.access.vpn.psk.length"throwing error for value < 8 and value > 256
right now, 8, 256 are hardcoded in the code. They should be moved to a
constant and has to be reused everywhere.

will update with test cases/testing later.

* pr/929:
  CLOUDSTACK-8951: validation for "remote.access.vpn.psk.length"

Signed-off-by: Remi Bergsma <git...@remi.nl>


> UI is not throwing any error message to user when 
> "remote.access.vpn.psk.length" is set to less than minimum value (min8)
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8951
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8951
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rajani Karuturi
>            Priority: Critical
>
> 1. Changed the global configuration "remote.access.vpn.psk.length" to 5 but 
> the minimum value is 8.
> 2. restart the MS.
> Ms failed to restart with following exception:
> 015-09-16 06:08:54,230 INFO  [o.a.c.f.m.MessageDispatcher] (main:null) 
> (logid:) Build message handler cache for 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobMonitor
> 2015-09-16 06:08:54,230 INFO  [o.a.c.f.m.MessageDispatcher] (main:null) 
> (logid:) Add message handler 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobMonitor.onJobHeartbeatNotify
>  to cache
> 2015-09-16 06:08:54,230 INFO  [o.a.c.f.m.MessageDispatcher] (main:null) 
> (logid:) Done building message handler cache for 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobMonitor
> 2015-09-16 06:08:54,231 DEBUG [c.c.a.m.AgentManagerImpl] (main:null) (logid:) 
> Registering listener DeploymentPlanningManagerImpl with id 9
> 2015-09-16 06:08:54,278 ERROR [o.a.c.s.l.CloudStackExtendedLifeCycle] 
> (main:null) (logid:) Failed to configure RemoteAccessVpnManagerImpl
> javax.naming.ConfigurationException: Remote Access VPN: IPSec preshared key 
> length should be between 8 and 256
>         at 
> com.cloud.network.vpn.RemoteAccessVpnManagerImpl.validateRemoteAccessVpnConfiguration(RemoteAccessVpnManagerImpl.java:268)
>         at 
> com.cloud.network.vpn.RemoteAccessVpnManagerImpl.configure(RemoteAccessVpnManagerImpl.java:694)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at $Proxy233.configure(Unknown Source)
>         at 
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle$3.with(CloudStackExtendedLifeCycle.java:114)
>         at 
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.with(CloudStackExtendedLifeCycle.java:153)
>         at 
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.configure(CloudStackExtendedLifeCycle.java:110)
>         at 
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:56)
>         at 
> org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:167)
>         at 
> org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:51)
>         at 
> org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:339)
>         at 
> org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:143)
>         at org
> But Even before restart of MS,
> UI should throw proper error message to the user.
> Attaching the Mslogs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to