[ https://issues.apache.org/jira/browse/CLOUDSTACK-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030151#comment-15030151 ]
ASF GitHub Bot commented on CLOUDSTACK-8958: -------------------------------------------- Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r46066286 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final DedicatePublicIpRangeCmd cmd) throws Res vlanOwner = _accountMgr.getAccount(project.getProjectAccountId()); } + Domain domain = null; if (accountName != null && domainId != null) { vlanOwner = _accountDao.findActiveAccount(accountName, domainId); - } - if (vlanOwner == null) { - throw new InvalidParameterValueException("Unable to find account by name " + accountName); - } else if (vlanOwner.getId() == Account.ACCOUNT_ID_SYSTEM) { - throw new InvalidParameterValueException("Please specify a valid account. Cannot dedicate IP range to system account"); + if (vlanOwner == null) { --- End diff -- @koushik-das You OK with the PR like it is now? Please review again, thanks! > add dedicated ips to domain > --------------------------- > > Key: CLOUDSTACK-8958 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8958 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Wei Zhou > Assignee: Wei Zhou > > add dedicated ips to domain > ips are dedicated to Account for now, so other customers and projects in the > same domain will use the system ip. this is not what we need. -- This message was sent by Atlassian JIRA (v6.3.4#6332)