[ https://issues.apache.org/jira/browse/CLOUDSTACK-8988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037558#comment-15037558 ]
ASF GitHub Bot commented on CLOUDSTACK-8988: -------------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/943 > CLOUDSTACK-8988 > --------------- > > Key: CLOUDSTACK-8988 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8988 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, Projects > Affects Versions: 4.7.0 > Environment: Windows 10; Eclipse; > Reporter: Rodrigo Pedro Marques > Priority: Minor > Labels: easyfix, github-import > Fix For: 4.7.0 > > Original Estimate: 0h > Remaining Estimate: 0h > > Removal of cloud-plugin-storage-allocator-random project that was unused. > File modified: /cloud-server/test/async-job-component.xml. Removed some > unused adapters.The reason for this is explained as follows. > The adapter configuration is the following: > <adapters key="com.cloud.agent.manager.allocator.StorageAllocator"> > <adapter name="Storage" > class="com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator"> > <param name="storage.overprovisioning.factor">2</param> > </adapter> > <adapter name=" > class="com.cloud.agent.manager.allocator.impl.RandomStoragePoolAllocator"> > <param name="storage.overprovisioning.factor">2</param> > </adapter> > </adapters> > • class="com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator" > The class "com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator" > does not exist. The only reference for it is found in the following file: > - /cloud-server/test/async-job-component.xml > Therefore, we can conclude that there is no need for this line at that file. > • class="com.cloud.agent.manager.allocator.impl.RandomStoragePoolAllocator" > Additionally, the class RandomStoragePoolAllocator.java is never used. The > only reference is found in the following file: > /cloud-server/test/async-job-component.xml > We found a project called “cloud-plugin-storage-allocator-random”. This > project has only one package that contains only one class, which is the > RandomStoragePoolAllocator.java. Despite the names that are the same, the > class in “cloud-plugin-storage-allocator-random” project and the class > referenced in - /cloud-server/test/async-job-component.xml have different > packages. Therefore, we removed that configuration from > async-job-component.xml and the project that contains only the > RandomStoragePoolAllocator class that is never used. > Consequently, we had to remove the following lines from the > /cloud-client-ui/pom.xml: > <dependency> > <groupId>org.apache.cloudstack</groupId> > <artifactId>cloud-plugin-storage-allocator-random</artifactId> > <version>${project.version}</version> > </dependency> > Those changes leave us with an adapter configuration empty with the following > key: > • key="com.cloud.agent.manager.allocator.StorageAllocator" > Therefore, we removed it. > Furthermore, after we removed that configuration we noticed that there is no > such class StorageAllocator.java. However, it appears that exists test for > it, like the following classes: > StorageAllocatorTestConfiguration.java > StorageAllocatorTest.java. We are not sure if these classes are tests for the > class StorageAllocator.java and for the possible configuration we have just > removed. If they are, we can remove both classes. > We also removed the following configuration from /cloudstack-plugins/pom.xml: > <module>storage-allocators/random</module> -- This message was sent by Atlassian JIRA (v6.3.4#6332)