[ https://issues.apache.org/jira/browse/CLOUDSTACK-9102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037662#comment-15037662 ]
ASF GitHub Bot commented on CLOUDSTACK-9102: -------------------------------------------- GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/1156 Fixed issues with test_vpc_vpn script There are few issues with this test file. Please refer to JIRA Ticket https://issues.apache.org/jira/browse/CLOUDSTACK-9102 for details on the issues that have been fixed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sanju1010/cloudstack testvpn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1156 ---- commit 09409a7ac264e864c45146927b86229c8e67fbc8 Author: sanjeevn <sanjeev.neelar...@citrix.com> Date: 2015-12-03T10:26:08Z Fixed issues with test_vpc_vpn script ---- > Resolve issues with test_vpc_vpn.py test suite file > --------------------------------------------------- > > Key: CLOUDSTACK-9102 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9102 > Project: CloudStack > Issue Type: Test > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Sanjeev N > Assignee: Sanjeev N > > Following issues are found in test_vpc_vpn.py file: > 1. UnboundLocalError: > This is because we are using some variables before assignment. This is > related to python syntax and requires a code change > 2. Template registration based on the hypervisor: > The functionality in this test is nothing to do with template registration. > So remove template registration part and make it generic for all the > hypervisors > 3. Getting default vpc offering from the list of vpc offerings: > Test was listing default vpc offerings and taking the first one from the > list. Hoever, cloudstack provides three default vpc offerings and first one > in the list is always the Nuage VPC offering. So if we try to create vpc with > this offering it will fail because we would not have the Nuage service > provider in the physical network. So need to change the way we get the > default vpc offering. -- This message was sent by Atlassian JIRA (v6.3.4#6332)