[
https://issues.apache.org/jira/browse/CLOUDSTACK-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037780#comment-15037780
]
ASF GitHub Bot commented on CLOUDSTACK-8892:
--------------------------------------------
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1158#issuecomment-161641914
-1
I don't think it is a good idea to reboot routers when out-of-band
operation is detected. We discussed this before, let's not do it again. Please
search the archives on this subject.
We use out-of-band migrations when patching and this way I can migrate
1000s of routers out-of-band without issues. This is on XenServer and KVM. Your
code change seems to make them reboot all, which would be a disaster. It's not
even needed.
> If VR enters out-of band context, routers lose their private/link-local IP.
> ---------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8892
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8892
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Maneesha
> Assignee: Maneesha
>
> If VR enters out-of band context ( here by mis-match in power state report
> from hypervisor ), routers lose their link-local IP (private IP in VMware)
> nor is there any information of IP in the nics tab.
> {noformat}
> 2015-02-11 06:48:22,090 INFO [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (DirectAgent-320:ctx-b767cd3d) Schedule a router reboot task as router 1838
> is powered-on out-of-band. we need to reboot to refresh network rules
> 2015-02-11 06:48:22,091 INFO [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (DirectAgent-320:ctx-b767cd3d) Schedule a router reboot task as router 1838
> is powered-on out-of-band. we need to reboot to refresh network rules
> 2015-02-11 07:20:11,616 INFO [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (RouterMonitor-1:ctx-c16552e1) Reboot router 1838 to refresh network rules
> 2015-02-11 07:20:11,624 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (RouterMonitor-1:ctx-c16552e1) Stopping and starting router
> VM[DomainRouter|r-1838-VM] as a part of router reboot
> 2015-02-11 07:20:11,624 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (RouterMonitor-1:ctx-c16552e1) Stopping router VM[DomainRouter|r-1838-VM]
> 2015-02-11 07:20:14,692 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (RouterMonitor-1:ctx-c16552e1) Error while rebooting the router
> java.lang.RuntimeException: Job failed due to exception Unable to stop
> VM[DomainRouter|r-1838-VM]
> at
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:113)
> at
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:543)
> at
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:50)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:47)
> at
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:500)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
