[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041456#comment-15041456
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9086:
--------------------------------------------

Github user kansal commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1125#discussion_r46673005
  
    --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
    @@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final 
String ipAddress, final String
             return isInRange;
         }
     
    +    public static boolean isNetworkorBroadcastIP(String ip, String 
netmask){
    --- End diff --
    
    @DaanHoogland Sure I can do that. 


> ACS allows to create isolated networks with invalid gateway IP address
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9086
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9086
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Kshitij Kansal
>            Assignee: Kshitij Kansal
>
> When entering invalid combination no check is performed anymore and VR is 
> created with invalid interface. Of course, nothing works in the isolated 
> network. For example, you are allowed to create network with 172.16.21.0 IP 
> address for GW and 255.255.255.0 for SM - this address is not valid, however 
> it is accepted and even used in VR. One more example - 192.168.255.255 for GW 
> address and 255.255.255.0 for SM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to