[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043463#comment-15043463
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9106:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1179#discussion_r46761920
  
    --- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
    @@ -509,10 +512,11 @@ public boolean applyIps(final Network network, final 
List<? extends PublicIpAddr
                 final DataCenterVO dcVO = 
_dcDao.findById(network.getDataCenterId());
                 final NetworkTopology networkTopology = 
networkTopologyContext.retrieveNetworkTopology(dcVO);
     
    -            return networkTopology.associatePublicIP(network, ipAddress, 
routers);
    -        } else {
    -            return false;
    +            for (final DomainRouterVO domainRouterVO : routers) {
    +                result = networkTopology.associatePublicIP(network, 
ipAddress, domainRouterVO);
    --- End diff --
    
    &= these constructs only return the last result.


> As a Developer I want the Redundant VPC private gateway feature fixed
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9106
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9106
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.7.0
>
>
> Bug in BasicNetworkTopology.applyRules() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to