[
https://issues.apache.org/jira/browse/CLOUDSTACK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043757#comment-15043757
]
ASF GitHub Bot commented on CLOUDSTACK-9106:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46767881
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final Network network,
final List<PortForwardingRule
return true;
}
- DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
- NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
-
- return networkTopology.applyFirewallRules(network, rules, routers);
+ final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
+ final NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
+ for (final DomainRouterVO domainRouterVO : routers) {
+ result = networkTopology.applyFirewallRules(network, rules,
domainRouterVO);
--- End diff --
Sorry, i did not notice. Where did you say that?
I saw some other places where you bail on the first fail. I don't like that
solution:
If the first fails nothing is applied.
If the second fails the first router has the rules applied.
with &= it is symmetrical.
> As a Developer I want the Redundant VPC private gateway feature fixed
> ---------------------------------------------------------------------
>
> Key: CLOUDSTACK-9106
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9106
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.7.0
>
>
> Bug in BasicNetworkTopology.applyRules() method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
