[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044108#comment-15044108
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8968:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1150#discussion_r46775285
  
    --- Diff: ui/scripts/instanceWizard.js ---
    @@ -731,25 +746,33 @@
     
                 //step 1 : select zone
                 $.extend(deployVmData, {
    -                zoneid : args.data.zoneid
    +                zoneid : selectedZoneObj.id
                 });
     
                 //step 2: select template
    -            $.extend(deployVmData, {
    -                templateid : args.data.templateid
    -            });
    +            if (snapshotObjs) {
    +                $.extend(deployVmData, {
    +                    vmsnapshotid : selectedSnapshotObj.id
    +                });
    +            }
    +            else {
    +                $.extend(deployVmData, {
    +                    templateid : args.data.templateid
    +                });
    +            }
     
                 $.extend(deployVmData, {
                     hypervisor : selectedHypervisor
                 });
     
    -            if 
(args.$wizard.find('input[name=rootDiskSize]').parent().css('display') != 
'none')  {
    -                if 
(args.$wizard.find('input[name=rootDiskSize]').val().length > 0) {
    -                    $.extend(deployVmData, {
    -                        rootdisksize : 
args.$wizard.find('input[name=rootDiskSize]').val()
    -                    });
    -                }
    -            }
    +//            Currently it is not supporting in backend
    +//            if 
(args.$wizard.find('input[name=rootDiskSize]').parent().css('display') != 
'none')  {
    --- End diff --
    
    please do not leave code commented in. this block should be deleted.


> UI icon over VM snapshot to deploy user instance
> ------------------------------------------------
>
>                 Key: CLOUDSTACK-8968
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8968
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nitin Kumar Maharana
>
> A new icon over VM snapshot object, which upon invoked will open a deploy 
> user instance wizard, where there is no choice to choose zone and ISO or 
> template to deploy the user instance from.
> 1) A new icon to indicate deploy user instance from VM snapshot
> 2) The new icon is placed as an operation over each VM snapshot object.
> 3) Clicking this icon will show the wizard to deploy user instance, which is 
> same as wizard for normal user instance except that zone selection page and 
> ISO/template selection page would not be present in this wizard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to