[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052915#comment-15052915
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9129:
--------------------------------------------

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1197#issuecomment-163967401
  
    We used separate environment, but provided by the same infra.
    
    What I don't get is why the tests are being executed from 
```/data/git/cs1/cloudstack/test/integration/component/test_routers_network_ops.py```,
 whilst I moved them to ```smoke``` directory a couple of days ago.
    
    I'm running the same tests - for KVM - a some changes I'm about to create a 
PR for. Those changes are only tests related, so no code has changed. In 
addition, I have rebased with latest master before creating my branch and the 
result from the same test I get is:
    
    ```
    Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
    ok
    ```
    
    I think you are running from the component directory, which does not 
contain the test but might contain the ```pyc``` file. Just a thought. 
    
    I don't see why this PR would break 1 test only. It happened with 2 people, 
but both of them were running tests that might not even exist anymore...?
    
    @ustcweizhou @remibergsma @DaanHoogland I give my LGTM for this. If we find 
out some weird stuff, we just revert it.
    
    Cheers,
    Wilder


> Cannot list vpc routers by keyword in Infrastructure -> Virtual Routers
> -----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9129
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9129
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>
> when search by keyword  in Infrastructure -> Virtual Routers page, it lists 
> only the routers searched by name/instancename/networkname, but not vpc name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to