[ https://issues.apache.org/jira/browse/CLOUDSTACK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053185#comment-15053185 ]
ASF GitHub Bot commented on CLOUDSTACK-9138: -------------------------------------------- Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1215#issuecomment-164014731 LGTM, both offerings mentioned above are created fine: ``` [root@cs1 integration]# cloudmonkey ☁ Apache CloudStack � cloudmonkey 5.3.2. Type help or ? to list commands. Using management server profile: local (local) � > create vpcoffering name=test2 displaytext=testtest2 supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb serviceproviderlist[0].service=PortForwarding serviceproviderlist[0].provider=VpcVirtualRouter serviceproviderlist[1].service=StaticNat serviceproviderlist[1].provider=VpcVirtualRouter serviceproviderlist[2].service=SourceNat serviceproviderlist[2].provider=VpcVirtualRouter serviceproviderlist[3].service=Vpn serviceproviderlist[3].provider=VpcVirtualRouter serviceproviderlist[4].service=Dhcp serviceproviderlist[4].provider=VpcVirtualRouter serviceproviderlist[5].service=Connectivity serviceproviderlist[5].provider=NiciraNvp serviceproviderlist[6].service=Dns serviceproviderlist[6].provider=VpcVirtualRouter serviceproviderlist[7].service=UserData serviceproviderlist[7].provider=VpcVirtualRouter serviceproviderlist[8].service=NetworkACL serviceproviderlist[8].provider=VpcVirtualRouter serviceproviderlist[9].service=Lb serviceproviderlist[9].provider=VpcVirtualRouter servicecapabilitylist[0].capabilitytype=RedundantRouter servicecapabilitylist[0].service=SourceNat servicecapabilitylist[0].capabilityvalue=true accountid = 634eafef-a034-11e5-b0bf-5254001daa61 cmd = org.apache.cloudstack.api.command.admin.vpc.CreateVPCOfferingCmd created = 2015-12-11T18:43:24+0000 jobid = af045abf-a7bf-4071-986b-60003e686de1 jobinstancetype = None jobprocstatus = 0 jobresult: vpcoffering: name = test2 id = 9e2cffe5-e1df-40ed-a19f-c99d0b0efcaa displaytext = testtest2 distributedvpcrouter = False isdefault = False service: name = Vpn provider: name = VpcVirtualRouter ================================================================================ name = Dns provider: name = VpcVirtualRouter ================================================================================ name = Connectivity provider: name = NiciraNvp ================================================================================ name = NetworkACL provider: name = VpcVirtualRouter ================================================================================ name = Dhcp provider: name = VpcVirtualRouter ================================================================================ name = UserData provider: name = VpcVirtualRouter ================================================================================ name = SourceNat provider: name = VpcVirtualRouter ================================================================================ name = PortForwarding provider: name = VpcVirtualRouter ================================================================================ name = Lb provider: name = VpcVirtualRouter ================================================================================ name = StaticNat provider: name = VpcVirtualRouter state = Disabled supportsregionLevelvpc = False jobresultcode = 0 jobresulttype = object jobstatus = 1 userid = 634ec46c-a034-11e5-b0bf-5254001daa61 (local) � > create vpcoffering name=test displaytext=testtest supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb serviceproviderlist[0].service=PortForwarding serviceproviderlist[0].provider=VpcVirtualRouter serviceproviderlist[1].service=StaticNat serviceproviderlist[1].provider=VpcVirtualRouter serviceproviderlist[2].service=SourceNat serviceproviderlist[2].provider=VpcVirtualRouter serviceproviderlist[3].service=Vpn serviceproviderlist[3].provider=VpcVirtualRouter serviceproviderlist[4].service=Dhcp serviceproviderlist[4].provider=VpcVirtualRouter serviceproviderlist[5].service=Connectivity serviceproviderlist[5].provider=NiciraNvp serviceproviderlist[6].service=Dns serviceproviderlist[6].provider=VpcVirtualRouter serviceproviderlist[7].service=UserData serviceproviderlist[7].provider=VpcVirtualRouter serviceproviderlist[8].service=NetworkACL serviceproviderlist[8].provider=VpcVirtualRouter serviceproviderlist[9].service=Lb serviceproviderlist[9].provider=VpcVirtualRouter serviceproviderlist[10].service=Lb serviceproviderlist[10].provider=InternalLbVm servicecapabilitylist[0].capabilitytype=RedundantRouter servicecapabilitylist[0].service=SourceNat servicecapabilitylist[0].capabilityvalue=true accountid = 634eafef-a034-11e5-b0bf-5254001daa61 cmd = org.apache.cloudstack.api.command.admin.vpc.CreateVPCOfferingCmd created = 2015-12-11T18:43:31+0000 jobid = 935a6cc5-e691-4224-8ec0-5158641a9f6d jobinstancetype = None jobprocstatus = 0 jobresult: vpcoffering: name = test id = edbe4cc4-dfba-4c04-ba09-08ddc7bd485d displaytext = testtest distributedvpcrouter = False isdefault = False service: name = Vpn provider: name = VpcVirtualRouter ================================================================================ name = Dns provider: name = VpcVirtualRouter ================================================================================ name = Connectivity provider: name = NiciraNvp ================================================================================ name = NetworkACL provider: name = VpcVirtualRouter ================================================================================ name = Dhcp provider: name = VpcVirtualRouter ================================================================================ name = UserData provider: name = VpcVirtualRouter ================================================================================ name = SourceNat provider: name = VpcVirtualRouter ================================================================================ name = PortForwarding provider: name = VpcVirtualRouter ================================================================================ name = Lb provider: name = InternalLbVm ================================================================================ name = VpcVirtualRouter ================================================================================ name = StaticNat provider: name = VpcVirtualRouter state = Disabled supportsregionLevelvpc = False jobresultcode = 0 jobresulttype = object jobstatus = 1 userid = 634ec46c-a034-11e5-b0bf-5254001daa61 (local) � > ``` > As a Developer I want the createVpcOffering to allow multiple provider per > service > ---------------------------------------------------------------------------------- > > Key: CLOUDSTACK-9138 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9138 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Affects Versions: 4.6.1 > Reporter: Wilder Rodrigues > Assignee: Wilder Rodrigues > Fix For: 4.7.0 > > > The default offerings already have multiple providers per service (e.g. Lb > with VpcRouterProvider and InternalLbVm) > It's very important that we can do the same from a developer/user point of > view. -- This message was sent by Atlassian JIRA (v6.3.4#6332)