[
https://issues.apache.org/jira/browse/CLOUDSTACK-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056162#comment-15056162
]
ASF GitHub Bot commented on CLOUDSTACK-9166:
--------------------------------------------
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164474404
@rafaelweingartner
It's not about throwing stones, it's about the process.
Simply put: 2 LGTM, and depending on the PR at least 1 with integration
tests executed. In this case, integration tests were not needed. It is a very
simple PR which could have been reviewed very quickly and none of this would
have happened. The whole storm behind it is that we have to keep the process
and avoid that something like that happens with more complex code - as it
happened just after 4.6.0.
Let's save some typing and time and not start a discussion about the
obvious.
Cheers,
Wilder
> Build failed in Jenkins: cloudstack-rat-master #7038
> ----------------------------------------------------
>
> Key: CLOUDSTACK-9166
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9166
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: sudharma jain
> Priority: Blocker
>
> See <https://builds.apache.org/job/cloudstack-rat-master/7038/changes>
> Changes:
> [sudharma.jain] CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux
> Enterprise
> ------------------------------------------
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> [EnvInject] - Loading node environment variables.
> Building remotely on ubuntu-1 (docker Ubuntu ubuntu ubuntu1) in workspace
> <https://builds.apache.org/job/cloudstack-rat-master/ws/>
> > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the
> remote Git repository > git config remote.origin.url
> https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10 Fetching
> upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git
> > git --version # timeout=10
> > git -c core.askpass=true fetch --tags --progress
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
> +refs/heads/*:refs/remotes/origin/*
> > git rev-parse origin/master^{commit} # timeout=10 Checking out Revision
> 2478414d471f6f72ff8c696ffc1c9b80b65766a1 (origin/master) > git config
> core.sparsecheckout # timeout=10 > git checkout -f
> 2478414d471f6f72ff8c696ffc1c9b80b65766a1
> > git rev-list 7c83e1b2402db9e359fb086b158d65c25309a70e # timeout=10
> [cloudstack-rat-master] $
> /home/jenkins/jenkins-slave/tools/hudson.tasks.Maven_MavenInstallation/Maven_3.0.5/bin/mvn
> --projects=org.apache.cloudstack:cloudstack
> org.apache.rat:apache-rat-plugin:0.10:check
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building Apache CloudStack 4.7.0-SNAPSHOT [INFO]
> ------------------------------------------------------------------------
> [INFO]
> [INFO] --- apache-rat-plugin:0.10:check (default-cli) @ cloudstack --- [INFO]
> 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: CHANGES.md
> [INFO] Exclude: README.md
> [INFO] Exclude: INSTALL.md
> [INFO] Exclude: CONTRIBUTING.md
> [INFO] Exclude: tools/docker/Dockerfile
> [INFO] Exclude: tools/docker/supervisord.conf [INFO] Exclude: .idea/ [INFO]
> Exclude: **/*.log [INFO] Exclude: **/*.patch [INFO] Exclude: **/.classpath
> [INFO] Exclude: **/.project [INFO] Exclude: **/.idea/** [INFO] Exclude:
> **/*.iml [INFO] Exclude: **/.settings/** [INFO] Exclude: .metadata/** [INFO]
> Exclude: .git/** [INFO] Exclude: .gitignore [INFO] Exclude: **/*.crt [INFO]
> Exclude: **/*.csr [INFO] Exclude: **/*.key [INFO] Exclude: **/authorized_keys
> [INFO] Exclude: **/*.war [INFO] Exclude: **/*.mar [INFO] Exclude: **/*.jar
> [INFO] Exclude: **/*.iso [INFO] Exclude: **/*.tgz [INFO] Exclude: **/*.zip
> [INFO] Exclude: **/target/** [INFO] Exclude: **/.vagrant [INFO] Exclude:
> **/*.json [INFO] Exclude: build/build.number [INFO] Exclude:
> services/console-proxy/server/js/jquery.js
> [INFO] Exclude: debian/compat
> [INFO] Exclude: debian/control
> [INFO] Exclude: debian/dirs
> [INFO] Exclude: debian/rules
> [INFO] Exclude: debian/source/format
> [INFO] Exclude: dist/console-proxy/js/jquery.js [INFO] Exclude:
> plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.sln
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/packages/**
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/**
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/obj/**
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/bin/**
> [INFO] Exclude:
> plugins/hypervisors/hyperv/DotNet/ServerResource/**/packages.config
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/App.config
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/*.csproj
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/*.settings
> [INFO] Exclude: plugins/hypervisors/hyperv/conf/agent.properties
> [INFO] Exclude: scripts/vm/systemvm/id_rsa.cloud [INFO] Exclude:
> services/console-proxy/server/conf/agent.properties
> [INFO] Exclude: services/console-proxy/server/conf/environment.properties
> [INFO] Exclude: services/secondary-storage/conf/agent.properties
> [INFO] Exclude: services/secondary-storage/conf/environment.properties
> [INFO] Exclude: test/systemvm/README.md
> [INFO] Exclude: tools/appliance/.ruby-version [INFO] Exclude:
> tools/vagrant/systemvm/vagrant.pub
> [INFO] Exclude: tools/vagrant/systemvm/.ruby-version
> [INFO] Exclude:
> tools/devcloud/basebuild/puppet-devcloudinitial/files/network.conf
> [INFO] Exclude: tools/appliance/definitions/devcloud/*
> [INFO] Exclude: tools/appliance/definitions/systemvmtemplate/*
> [INFO] Exclude: tools/appliance/definitions/systemvm64template/*
> [INFO] Exclude: tools/appliance/definitions/builtin/*
> [INFO] Exclude: tools/cli/cloudmonkey.egg-info/* [INFO] Exclude:
> tools/devcloud/src/deps/boxes/basebox-build/definition.rb
> [INFO] Exclude: tools/devcloud/src/deps/boxes/basebox-build/preseed.cfg
> [INFO] Exclude: tools/marvin/Marvin.egg-info/* [INFO] Exclude:
> ui/css/token-input-facebook.css [INFO] Exclude:
> ui/lib/flot/jquery.colorhelpers.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.crosshair.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.fillbetween.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.image.js [INFO] Exclude:
> ui/lib/flot/jquery.flot.js [INFO] Exclude: ui/lib/flot/jquery.flot.navigate.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.pie.js [INFO] Exclude:
> ui/lib/flot/jquery.flot.resize.js [INFO] Exclude:
> ui/lib/flot/jquery.flot.selection.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.stack.js [INFO] Exclude:
> ui/lib/flot/jquery.flot.symbol.js [INFO] Exclude:
> ui/lib/flot/jquery.flot.threshold.js
> [INFO] Exclude: ui/lib/jquery-ui/css/jquery-ui.css
> [INFO] Exclude: ui/lib/jquery-ui/index.html [INFO] Exclude:
> ui/lib/jquery-ui/js/jquery-ui.js [INFO] Exclude: ui/lib/jquery.cookies.js
> [INFO] Exclude: ui/lib/jquery.easing.js [INFO] Exclude: ui/lib/jquery.js
> [INFO] Exclude: ui/lib/jquery.md5.js [INFO] Exclude:
> ui/lib/jquery.validate.js [INFO] Exclude: ui/lib/jquery.tokeninput.js [INFO]
> Exclude: ui/lib/qunit/qunit.css [INFO] Exclude: ui/lib/qunit/qunit.js [INFO]
> Exclude: ui/lib/reset.css [INFO] Exclude: ui/lib/require.js [INFO] Exclude:
> systemvm/conf/agent.properties [INFO] Exclude:
> systemvm/conf/environment.properties
> [INFO] Exclude: systemvm/js/jquery.js
> [INFO] Exclude: systemvm/patches/debian/systemvm.vmx
> [INFO] Exclude: systemvm/patches/debian/config/root/.ssh/authorized_keys
> [INFO] Exclude: systemvm/patches/debian/config/etc/apache2/httpd.conf
> [INFO] Exclude: systemvm/patches/debian/config/etc/apache2/ports.conf
> [INFO] Exclude:
> systemvm/patches/debian/config/etc/apache2/sites-available/default
> [INFO] Exclude:
> systemvm/patches/debian/config/etc/apache2/sites-available/default-ssl
> [INFO] Exclude: systemvm/patches/debian/config/etc/apache2/vhostexample.conf
> [INFO] Exclude: systemvm/patches/debian/config/etc/dnsmasq.conf.tmpl
> [INFO] Exclude: systemvm/patches/debian/config/etc/vpcdnsmasq.conf
> [INFO] Exclude: systemvm/patches/debian/config/etc/ssh/sshd_config
> [INFO] Exclude: systemvm/patches/debian/config/etc/rsyslog.conf
> [INFO] Exclude: systemvm/patches/debian/config/etc/logrotate.conf
> [INFO] Exclude: systemvm/patches/debian/config/etc/logrotate.d/*
> [INFO] Exclude: systemvm/patches/debian/config/etc/sysctl.conf
> [INFO] Exclude:
> systemvm/patches/debian/config/root/redundant_router/keepalived.conf.templ
> [INFO] Exclude:
> systemvm/patches/debian/config/root/redundant_router/arping_gateways.sh.templ
> [INFO] Exclude:
> systemvm/patches/debian/config/root/redundant_router/conntrackd.conf.templ
> [INFO] Exclude: systemvm/patches/debian/vpn/etc/ipsec.conf
> [INFO] Exclude: systemvm/patches/debian/vpn/etc/ppp/options.xl2tpd
> [INFO] Exclude: systemvm/patches/debian/vpn/etc/xl2tpd/xl2tpd.conf
> [INFO] Exclude: systemvm/patches/debian/vpn/etc/ipsec.secrets
> [INFO] Exclude: systemvm/patches/debian/config/etc/haproxy/haproxy.cfg
> [INFO] Exclude: systemvm/patches/debian/config/etc/cloud-nic.rules
> [INFO] Exclude: systemvm/patches/debian/config/etc/modprobe.d/aesni_intel
> [INFO] Exclude: systemvm/patches/debian/config/etc/rc.local
> [INFO] Exclude: systemvm/patches/debian/config/var/www/html/userdata/.htaccess
> [INFO] Exclude: systemvm/patches/debian/config/var/www/html/latest/.htaccess
> [INFO] Exclude: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf
> [INFO] Exclude: tools/transifex/.tx/config [INFO] Exclude:
> tools/logo/apache_cloudstack.png [INFO] Exclude:
> tools/marvin/marvin/sandbox/advanced/sandbox.cfg
> [INFO] Exclude: tools/ngui/static/bootstrap/* [INFO] Exclude:
> tools/ngui/static/js/lib/* [INFO] Exclude: **/.checkstyle [INFO] Exclude:
> scripts/installer/windows/acs_license.rtf
> [INFO] Exclude: **/*.md
> [INFO] 7231 resources included (use -debug for more details) [INFO] Rat
> check: Summary of files. Unapproved: 1 unknown: 1 generated: 0 approved: 7108
> licence.
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 14.466s
> [INFO] Finished at: Mon Dec 14 11:02:04 UTC 2015 [INFO] Final Memory:
> 32M/382M [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.10:check
> (default-cli) on project cloudstack: Too many files with unapproved license:
> 1 See RAT report in:
> <https://builds.apache.org/job/cloudstack-rat-master/7038/artifact/target/rat.txt>
> -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors,
> re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Build step 'Invoke top-level Maven targets' marked build as failure Archiving
> artifacts
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
