[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188754#comment-15188754
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9304:
--------------------------------------------

Github user shivsg commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1431#discussion_r55638247
  
    --- Diff: test/integration/component/test_nuage_vsp.py ---
    @@ -1,334 +0,0 @@
    -# Licensed to the Apache Software Foundation (ASF) under one
    -# or more contributor license agreements.  See the NOTICE file
    -# distributed with this work for additional information
    -# regarding copyright ownership.  The ASF licenses this file
    -# to you under the Apache License, Version 2.0 (the
    -# "License"); you may not use this file except in compliance
    -# with the License.  You may obtain a copy of the License at
    -#
    -#   http://www.apache.org/licenses/LICENSE-2.0
    -#
    -# Unless required by applicable law or agreed to in writing,
    -# software distributed under the License is distributed on an
    -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -# KIND, either express or implied.  See the License for the
    -# specific language governing permissions and limitations
    -# under the License.
    -
    -""" P1 tests for NuageVsp network Plugin
    -"""
    -# Import Local Modules
    -from nose.plugins.attrib import attr
    -from marvin.cloudstackTestCase import cloudstackTestCase
    -from marvin.cloudstackAPI import (listPhysicalNetworks,
    -                                  listNetworkServiceProviders,
    -                                  addNetworkServiceProvider,
    -                                  deleteNetworkServiceProvider,
    -                                  deleteNuageVspDevice,
    -                                  updateNetworkServiceProvider,
    -                                  addNuageVspDevice,
    -                                  destroyVirtualMachine)
    -from marvin.lib.utils import (cleanup_resources)
    -from marvin.lib.base import (Account,
    -                             VirtualMachine,
    -                             ServiceOffering,
    -                             NetworkOffering,
    -                             Network)
    -from marvin.lib.common import (get_domain,
    -                               get_zone,
    -                               get_template)
    -
    -import logging
    -import unittest
    -
    -
    -class Services:
    -
    -    """Test NuageVsp plugin
    -    """
    -
    -    def __init__(self):
    -        print "in __init__"
    -        self.services = {
    -            "account": {
    -                "email": "cloudst...@cloudmonkey.com",
    -                "firstname": "cloudstack",
    -                "lastname": "bob",
    -                "username": "admin",
    -                "password": "password",
    -            },
    -            "service_offering": {
    -                "name": "Tiny Instance",
    -                "displaytext": "Tiny Instance",
    -                "cpunumber": 1,
    -                "cpuspeed": 100,    # in MHz
    -                                    "memory": 128,       # In MBs
    -            },
    -            "virtual_machine": {
    -                "displayname": "TestVM",
    -                "username": "root",
    -                "password": "password",
    -                "ssh_port": 22,
    -                "hypervisor": 'KVM',
    -                "privateport": 22,
    -                "publicport": 22,
    -                "protocol": 'TCP',
    -            },
    -            "nuage_vsp_device": {
    -                "hostname": '172.31.222.162',
    -                "username": 'cloudstackuser1',
    -                "password": 'cloudstackuser1',
    -                "port": '8443',
    -                "apiversion": 'v3_2',
    -                "retrycount": '4',
    -                "retryinterval": '60'
    -            },
    -            # services supported by Nuage for isolated networks.
    -            "network_offering": {
    -                "name": 'nuage_marvin',
    -                "displaytext": 'nuage_marvin',
    -                "guestiptype": 'Isolated',
    -                "supportedservices":
    -                'Dhcp,SourceNat,Connectivity,StaticNat,UserData,Firewall',
    -                "traffictype": 'GUEST',
    -                "availability": 'Optional',
    -                "serviceProviderList": {
    -                    "UserData": 'VirtualRouter',
    -                    "Dhcp": 'NuageVsp',
    -                    "Connectivity": 'NuageVsp',
    -                    "StaticNat": 'NuageVsp',
    -                    "SourceNat": 'NuageVsp',
    -                    "Firewall": 'NuageVsp'
    -                },
    -                "serviceCapabilityList": {
    -                    "SourceNat": {"SupportedSourceNatTypes": "perzone"},
    -                }
    -            },
    -            "network": {
    -                "name": "nuage",
    -                "displaytext": "nuage",
    -            },
    -            "ostype": 'CentOS 5.5 (64-bit)',
    -            "sleep": 60,
    -            "timeout": 10
    -        }
    -
    -
    -class TestNuageVsp(cloudstackTestCase):
    -
    -    @classmethod
    -    def setUpClass(cls):
    -        print "In setup class"
    -        cls._cleanup = []
    -        cls.testClient = super(TestNuageVsp, cls).getClsTestClient()
    -        cls.api_client = cls.testClient.getApiClient()
    -
    -        cls.services = Services().services
    -        # Get Zone, Domain and templates
    -        cls.domain = get_domain(cls.api_client)
    -        cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
    -        cls.template = get_template(
    -            cls.api_client,
    -            cls.zone.id,
    -            cls.services["ostype"]
    -        )
    -        # nuage vsp device brings the Nuage virtual service platform into 
play
    -        cls.nuage_services = cls.services["nuage_vsp_device"]
    -        try:
    -
    -            resp = listPhysicalNetworks.listPhysicalNetworksCmd()
    -            print "in cls.setupClass- resp: %s" % resp
    -            resp.zoneid = cls.zone.id
    -            physical_networks = cls.api_client.listPhysicalNetworks(resp)
    -            for pn in physical_networks:
    -                if pn.isolationmethods=='VSP':
    -                    physical_network = pn
    --- End diff --
    
    OK. We can add that.


> Add nuagevsp userdata testcase (Cloudstack-9095) & Refactor existing testcases
> ------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9304
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9304
>             Project: CloudStack
>          Issue Type: Task
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Automation
>            Reporter: Sowmya Neeladhuri
>             Fix For: 4.9.0
>
>
> 1. Created folder / test / integration / plugins / nuagevsp 
>  2. Moved test_nuage_vpc_network.py , test_nuage_vsp.py from / test / 
> integration / component / – to---> / test / integration / plugins / nuagevsp/ 
>  3. Added new testcase test_nuage_password_reset.py (Cloudstack-9095) 
>  4. Added Nuage class in / tools / marvin / marvin / lib / base.py 
>  5. Added services in / tools / marvin / marvin / config / test_data.py
>  
> results: 
> test_01_UserDataPasswordReset 
> (nuagevsp.test_nuage_password_reset.TestNuagePasswordReset) ... === TestName: 
> test_01_UserDataPasswordReset | Status : SUCCESS ===
> ok
> Test Basic VPC Network Functionality with NuageVsp network Plugin ... === 
> TestName: test_nuage_vpc_network | Status : SUCCESS ===
> ok
> Test NuageVsp network plugin with basic Isolated Network functionality ... 
> === TestName: test_nuage_vsp | Status : SUCCESS ===
> ok
> ----------------------------------------------------------------------
> XML: /root/report_xunit.xml
> ----------------------------------------------------------------------
> Ran 3 tests in 2406.256s
> OK
> ~



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to