[
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199935#comment-15199935
]
ASF GitHub Bot commented on CLOUDSTACK-9297:
--------------------------------------------
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197975991
CloudStack iterates over all known snapshot strategies and asks each if it
can handle a particular situation (take, delete, revert) for a volume or volume
snapshot.
One with a priority higher than the others is selected.
If you can't handle the particular use case, you return CANT_HANDLE.
On Mar 17, 2016, at 12:49 PM, Rafael Weing?rtner
<[email protected]<mailto:[email protected]>> wrote:
Ok @mike-tutkowski<https://github.com/mike-tutkowski>, now I believe I
understand a little bit more of the code.
You are reusing a method that already exist and returns the
StrategyPriority (you did not create that method to suffice your code). I was
misled by the name of the method, when I first saw it, I thought that the
method was used solely to check if it can or cannot proceed with the snapshot
when in fact it is used to do much more.
I believe "getSnapshotStrategy" would be a more suitable name.
Now that I understand what we have there, I am ok with that conditional as
it
is.
-
You are receiving this because you were mentioned.
Reply to this email directly or view it on
GitHub<https://github.com/apache/cloudstack/pull/1441#issuecomment-197970382>
> delete snapshot without id is failing with Unable to determine the storage
> pool of the snapshot
> -----------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
> Reporter: Özhan Rüzgar Karaman
> Assignee: Mike Tutkowski
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
