[
https://issues.apache.org/jira/browse/CLOUDSTACK-8800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199581#comment-15199581
]
ASF GitHub Bot commented on CLOUDSTACK-8800:
--------------------------------------------
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r56509815
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4879,10 +4889,16 @@ private VirtualMachineGuestOsIdentifier
translateGuestOsIdentifier(String cpuArc
} else if
(objProp.getName().contains(instanceNameCustomField)) {
--- End diff --
Here it is the same as in CitrixResourceBase.java. I know you just followed
the way the code was written here before, but this “if/else/if/else……”
structure is too big; I believe to introduce some changes like this here; it
would be much appreciated a refactoring. I do not mean a huge refactoring, only
the extraction of this if/else structure to a method and then using some other
clever way to do these checks and to retrieve the values.
> Improve the listVirtualMachines API call to include memory utilization
> information for a VM
> -------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8800
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8800
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.5.2
> Reporter: Maneesha
> Assignee: Maneesha
> Fix For: 4.6.1
>
>
> Currently the feature of memory utilization is not available via API call
> (listVirtualMachines).
> https://cloudstack.apache.org/api/apidocs-4.5/root_admin/listVirtualMachines.html
>
> The listVirtualMachine get its values from the "user_vm_view" table in the
> database. Currently it shows the CPU utilization of the VM's.
> The only way to find out the memory utilization of VM's running on XenServer,
> is to run the "xentop" command on the pool master of the cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
