[
https://issues.apache.org/jira/browse/CLOUDSTACK-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224986#comment-15224986
]
ASF GitHub Bot commented on CLOUDSTACK-8611:
--------------------------------------------
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58442410
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.utils.ssh;
+
+import java.io.InputStream;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import com.trilead.ssh2.ChannelCondition;
+import com.trilead.ssh2.Session;
+
+@RunWith(MockitoJUnitRunner.class)
+public class SshHelperTest {
+
+ // throwSshExceptionIfConditionsTimeout tests
+ @Test(expected = SshException.class)
+ public void throwSshExceptionIfConditionsTimeoutTestTimeout() throws
SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.TIMEOUT);
+ }
+
+ @Test
+ public void throwSshExceptionIfConditionsTimeoutTestClosed() throws
SshException {
--- End diff --
@rafaelweingartner the tested method
("com.cloud.utils.ssh.SshHelper.throwSshExceptionIfConditionsTimeout(int)") has
to throw an exception only if the connection condition is of timeout
("ChannelCondition.TIMEOUT"). Thus, the test method
"com.cloud.utils.ssh.SshHelper.throwSshExceptionIfConditionsTimeout(int)" does
expect a SshException exception (with `@Test(expected = SshException.class)`);
otherwise, an exception is not expected and those tests check that the the
method does not throw the SshException.
> CS waits indefinitely for CheckS2SVpnConnectionsCommand to return
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-8611
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8611
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Likitha Shetty
> Assignee: Suresh Kumar Anaparti
> Fix For: 4.6.1
>
>
> On one instance, CS began to execute CheckS2SVpnConnectionsCommand command on
> a router but the command result was never returned to the MS. If a command
> never returns, then 'DirectAgent' thread executing this command is blocked
> indefinitely and cannot pick up any other request.
> Now since this command is designed to execute in sequence on a host and is
> run regularly, every execution of that command thereafter on that particular
> host ended up picking up a DirectAgent thread and waiting for the previous
> execution to complete. And hence overtime, the host ended up using and
> blocking all 'DirectAgent' threads indefinitely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
