[ https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235447#comment-15235447 ]
ASF GitHub Bot commented on CLOUDSTACK-8302: -------------------------------------------- Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-208439532 LGTM based on hardware lab testing of feature on 4.8 branch with PR applied. Wido, As far as I can tell, the changes to XenserverSnapshotStrategy look to be valid for KVM. > Cleanup snapshot on KVM with RBD > -------------------------------- > > Key: CLOUDSTACK-8302 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Snapshot, Storage Controller > Affects Versions: 4.4.0, 4.4.1, 4.4.2 > Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8 > Reporter: Star Guo > Assignee: Wido den Hollander > Priority: Critical > > I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8. > I deploy an instance on RBD and I create the ROOT volume snapshots. When > delete a snapshot the UI show OK, but the snapshot of the volume in the RBD > pool is still exist. > And I find the code in > com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: > … > @Override > public Answer deleteSnapshot(DeleteCommand cmd) { > return new Answer(cmd); > } > … > deleteSnapshot() does not be implememented. And I also find the code: > ... > @Override > public Answer createTemplateFromSnapshot(CopyCommand cmd) { > return null; //To change body of implemented methods use File | > Settings | File Templates. > } > ... > So does createTenokateFromSnapshot(). I just look for it in MASTER branch but > not do that yet. Will CloudStack Dev Team plan to do that ? Thanks . -- This message was sent by Atlassian JIRA (v6.3.4#6332)