[ https://issues.apache.org/jira/browse/CLOUDSTACK-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249699#comment-15249699 ]
ASF GitHub Bot commented on CLOUDSTACK-8611: -------------------------------------------- Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r60393439 --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java --- @@ -206,4 +216,87 @@ public static void scpTo(String host, int port, String user, File pemKeyFile, St conn.close(); } } + + /** + * It gets a {@link Session} from the given {@link Connection}; then, it waits + * {@value #WAITING_OPEN_SSH_SESSION} milliseconds before returning the session, given a time to + * ensure that the connection is open before proceeding the execution. + * + * @param conn --- End diff -- @GabrielBrascher this is the kind of javadoc I don't like. The header adds an explanation but these tags don't add value to the names of the params themselves. (just saying, no biggy) > CS waits indefinitely for CheckS2SVpnConnectionsCommand to return > ----------------------------------------------------------------- > > Key: CLOUDSTACK-8611 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8611 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Likitha Shetty > Assignee: Suresh Kumar Anaparti > Fix For: 4.9.0 > > > On one instance, CS began to execute CheckS2SVpnConnectionsCommand command on > a router but the command result was never returned to the MS. If a command > never returns, then 'DirectAgent' thread executing this command is blocked > indefinitely and cannot pick up any other request. > Now since this command is designed to execute in sequence on a host and is > run regularly, every execution of that command thereafter on that particular > host ended up picking up a DirectAgent thread and waiting for the previous > execution to complete. And hence overtime, the host ended up using and > blocking all 'DirectAgent' threads indefinitely. -- This message was sent by Atlassian JIRA (v6.3.4#6332)