[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251699#comment-15251699
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------

Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1489#issuecomment-212852849
  
    @jburwell I've fixed outstanding issues, including a framework level API 
arg validation (and removed such validations across cmd implementations)
    @koushik-das let me know if you've more questions
    
    Thanks all for the review, I believe all of the outstanding issues have 
been solved and fixed. /cc @swill 
    
    I've executed another test round locally and it looks good to me 
    ==== Marvin Init Started ====
    
    === Marvin Parse Config Successful ===
    
    === Marvin Setting TestData Successful===
    
    ==== Log Folder Path: /tmp//MarvinLogs//Apr_21_2016_16_16_18_FM3SK5. All 
logs will be available here ====
    
    === Marvin Init Logging Successful===
    
    ==== Marvin Init Successful ====
    === TestName: test_default_role_deletion | Status : SUCCESS ===
    
    === TestName: test_role_account_acls | Status : SUCCESS ===
    
    === TestName: test_role_account_acls_multiple_mgmt_servers | Status : 
SUCCESS ===
    
    === TestName: test_role_inuse_deletion | Status : SUCCESS ===
    
    === TestName: test_role_lifecycle_create | Status : SUCCESS ===
    
    === TestName: test_role_lifecycle_delete | Status : SUCCESS ===
    
    === TestName: test_role_lifecycle_list | Status : SUCCESS ===
    
    === TestName: test_role_lifecycle_update | Status : SUCCESS ===
    
    === TestName: test_role_lifecycle_update_role_inuse | Status : SUCCESS ===
    
    === TestName: test_rolepermission_lifecycle_create | Status : SUCCESS ===
    
    === TestName: test_rolepermission_lifecycle_delete | Status : SUCCESS ===
    
    === TestName: test_rolepermission_lifecycle_list | Status : SUCCESS ===
    
    === TestName: test_rolepermission_lifecycle_update | Status : SUCCESS ===
    
    === TestName: test_rolepermission_lifecycle_update_invalid_rule | Status : 
SUCCESS ===



> User Definable Roles
> --------------------
>
>                 Key: CLOUDSTACK-8562
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>            Reporter: Paul Angus
>            Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to