[
https://issues.apache.org/jira/browse/CLOUDSTACK-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260141#comment-15260141
]
ASF GitHub Bot commented on CLOUDSTACK-9349:
--------------------------------------------
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215083560
Ok, I have run this through my lab again and specifically ran the
test_volumes.py file. All tests passed. See below. I have also attached the
results dir as a zip file for review.
Test Volume attach/detach to VM (5 data volumes) ... === TestName:
test_01_volume_attach_detach | Status : SUCCESS ===
ok
Test Root Volume attach/detach to VM ... === TestName:
test_02_root_volume_attach_detach | Status : SUCCESS ===
ok
Test Attach volumes (max capacity) ... === TestName: test_01_volume_attach
| Status : SUCCESS ===
ok
Test attach volumes (more than max) to an instance ... === TestName:
test_02_volume_attach_max | Status : SUCCESS ===
ok
Test custom disk sizes beyond range ... === TestName:
test_deployVmWithCustomDisk | Status : SUCCESS ===
ok
Attach a created Volume to a Running VM ... === TestName:
test_01_attach_volume | Status : SUCCESS ===
ok
Detach a Volume attached to a VM ... === TestName: test_02_detach_volume |
Status : SUCCESS ===
ok
Delete a Volume unattached to an VM ... === TestName:
test_03_delete_detached_volume | Status : SUCCESS ===
ok
Create a volume under a non-root domain as non-root-domain user ... ===
TestName: test_create_volume_under_domain | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 9 tests in 539.126s
OK
@swill - Looking at the standard bubble test suite that is run, it doesn't
even run this test, so I thought it prudent in this case to run it specifically
and post the results. Once we get the bubble stuff standardized, I'm happy to
run the full test and post those results. Until then, I would like to submit
this PR for code review again.
> Unable to detach root volume when using Hypervisor Type KVM
> -----------------------------------------------------------
>
> Key: CLOUDSTACK-9349
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9349
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Volumes
> Affects Versions: 4.5.1, 4.6.2, 4.7.1, 4.8.0, 4.9.0
> Environment: Centos 7
> Reporter: Simon Weller
> Priority: Minor
> Fix For: 4.7.2
>
>
> Back in 4.5, support was added in CLOUDSTACK-6284 for detaching root volumes.
> The original support was meant to work with Xen, VMware and KVM.
> After chatting with fuflo in the Cloudstack irc channel, it was pointed out
> that a constraint was not correctly modified in VolumeApiServiceImpl.java to
> allow the detach to occur when vm.getHypervisorType() == HypervisorType.KVM.
> This is a very useful feature, as it allows us to simulate a snapshot revert
> with Ceph by using createVolume sourced from a snapshot, then detaching and
> reattaching the root volume (new root volume needs to be attached as
> device=0).
> I'm going to propose a PR for this shortly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
