[
https://issues.apache.org/jira/browse/CLOUDSTACK-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262874#comment-15262874
]
ASF subversion and git services commented on CLOUDSTACK-9349:
-------------------------------------------------------------
Commit 1979f42b2d24e7d3ddaa71eeb0a01fde51dfd976 in cloudstack's branch
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1979f42 ]
Merge pull request #1500 from myENA/KVM_root_detach
CLOUDSTACK-9349: Enable root disk detach for KVM with new Marvin testsThis PR
addresses the KVM detach/attach ROOT disks from VMs (CLOUDSTACK-9349). In
short, this allows the KVM Hypervisor, and I added the Simulator as a valid
hypervisor for ease of development and testing of marvin, to detach a root
volume and the reattach a root volume using the deviceid=0 flag to the
attachVolume API. I have also written a marvin integration test that verifies
this feature works for both KVM and the Simulator.
Below is the marvin results files of the full marvin test_volumes.py. All
tests pass, including the new root detach/attach, on our KVM lab running with
the patches in this PR.
[test_volumes_KIR4G3.zip](https://github.com/apache/cloudstack/files/223799/test_volumes_KIR4G3.zip)
* pr/1500:
Removed sleeps and used validateList as requested.
Added required_hardware="false" attr above test_02_root_volume_attach_detach
Modified test_volumes.py to include a hypervisor test for root attach/detach
testing
Let hypervisor type KVM and Simulator detach root volumes. Updated
test_volumes.py to include a test for detaching and reattaching a root volume
from a vm. I also had to update base.py to allow attach_volume to have the
parameter deviceid to be passed as needed.
Signed-off-by: Will Stevens <williamstev...@gmail.com>
> Unable to detach root volume when using Hypervisor Type KVM
> -----------------------------------------------------------
>
> Key: CLOUDSTACK-9349
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9349
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Volumes
> Affects Versions: 4.5.1, 4.6.2, 4.7.1, 4.8.0, 4.9.0
> Environment: Centos 7
> Reporter: Simon Weller
> Priority: Minor
> Fix For: 4.7.2
>
>
> Back in 4.5, support was added in CLOUDSTACK-6284 for detaching root volumes.
> The original support was meant to work with Xen, VMware and KVM.
> After chatting with fuflo in the Cloudstack irc channel, it was pointed out
> that a constraint was not correctly modified in VolumeApiServiceImpl.java to
> allow the detach to occur when vm.getHypervisorType() == HypervisorType.KVM.
> This is a very useful feature, as it allows us to simulate a snapshot revert
> with Ceph by using createVolume sourced from a snapshot, then detaching and
> reattaching the root volume (new root volume needs to be attached as
> device=0).
> I'm going to propose a PR for this shortly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
