[ https://issues.apache.org/jira/browse/CLOUDSTACK-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266981#comment-15266981 ]
ASF GitHub Bot commented on CLOUDSTACK-9368: -------------------------------------------- Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216293439 @rafaelweingartner @cristofolini I refactored unit tests based on your comments, I also removed <code>testStorageNfsVersionNotPresent</code> as it is covered by tests <code>checkStorageProcessorAndHandlerNfsVersionAttributeVersionSet</code> and <code>checkStorageProcessorAndHandlerNfsVersionAttributeVersionNotSet</code> > Fix for Support configurable NFS version for Secondary Storage mounts > --------------------------------------------------------------------- > > Key: CLOUDSTACK-9368 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9368 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware > Affects Versions: 4.9.0 > Reporter: Nicolas Vazquez > Fix For: 4.9.0 > > > This issue address a problem introduced in > [CLOUDSTACK-9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] in > which NFS version couldn't be changed after hosts resources were configured > on startup (for hosts using `VmwareResource`), and as host parameters didn't > include `nfs.version` key, it was set `null`. > h4. Proposed solution > In this proposed solution `nfsVersion` would be passed in `NfsTO` through > `CopyCommand` to `VmwareResource`, who will check if NFS version is still > configured or not. If not, it will use the one sent in the command and will > set it to its storage processor and storage handler. After those setups, it > will proceed executing command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)